avoid bugprone-exception-escape in Macro copy constructor

firewave · firewave · commit 495a1130939d · 2025-09-09T12:24:14.000+02:00
diff --git a/simplecpp.cpp b/simplecpp.cpp
@@ -1492,7 +1492,12 @@ namespace simplecpp {
         }
 
         Macro(const Macro &other) : nameTokDef(nullptr), files(other.files), tokenListDefine(other.files), valueDefinedInCode_(other.valueDefinedInCode_) {
-            *this = other;
+            // TODO: remove the try-catch
+            // avoid bugprone-exception-escape clang-tidy warning
+            try {
+                *this = other;
+            }
+            catch(const Error&) {}
         }
 
         ~Macro() {

Original file line number	Diff line number	Diff line change
`@@ -1492,7 +1492,12 @@ namespace simplecpp {`
`1492`	`1492`	`}`
`1493`	`1493`
`1494`	`1494`	`Macro(const Macro &other) : nameTokDef(nullptr), files(other.files), tokenListDefine(other.files), valueDefinedInCode_(other.valueDefinedInCode_) {`
`1495`		`- *this = other;`
	`1495`	`+ // TODO: remove the try-catch`
	`1496`	`+ // avoid bugprone-exception-escape clang-tidy warning`
	`1497`	`+ try {`
	`1498`	`+ *this = other;`
	`1499`	`+ }`
	`1500`	`+ catch(const Error&) {}`
`1496`	`1501`	`}`
`1497`	`1502`
`1498`	`1503`	`~Macro() {`