fixed #13939 - look for platform file relative to project file (first) with CLI #7612
Conversation
|
I thought the lookup stuff was almost done but this raises even more shortcomings/questions 🤬. |
| if (defaultSign != '\0') | ||
| mSettings.platform.defaultSign = defaultSign; |
There was a problem hiding this comment.
This does not reflect the left-to-right processing as the imported project might change this(?). Even more reason for #7293.
Also make me wonder if this flag could be set per file and thus needs to life inside FileSettings instead of the platform after all...
There was a problem hiding this comment.
Also make me wonder if this flag could be set per file and thus needs to life inside FileSettings instead of the platform after all...
I misunderstood first..
I guess you mean that some files could be compiled with -funsigned-char and other files could be compiled with -fsigned-char? That's weird but not impossible.
I'm not sure if we need to handle this case properly.
The defaultSign do belong in platform in my head.
There was a problem hiding this comment.
yeah. that seems to be a edge case to me. I am not 100% sure if we need to support analysing multi-platform builds in 1 analysis.
That is the misconception. The signedness of char has nothing to do with the platform. It is dependent on the compiler and can be controlled individually with a CLI option. It is like specifying the language or standard.
There was a problem hiding this comment.
We already set the platform type per file so this would be akin to that.
There was a problem hiding this comment.
Either way it is out of the scope of this PR.
No description provided.