-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fixed #13793 - added CLI option --{no-}analyze-all-vs-configs
#7480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One of the prerequisites for #7293. |
@@ -1605,10 +1609,22 @@ CmdLineParser::Result CmdLineParser::parseFromArgs(int argc, const char* const a | |||
return Result::Fail; | |||
} | |||
|
|||
// TODO: conflicts with analyzeAllVsConfigs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have like four different ways to select a Visual Studio configuration from the GUI and CLI. At least the code doing it should be unified (if possible). But something for later after the import/CLI handling has been cleaned up and has better test coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have like four different ways to select a Visual Studio configuration from the GUI and CLI.
ouch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so as far as I see this will not be an "official" option to start with.. i.e. not shown in the --help output.. which will make it easier to unify later.
@@ -1605,10 +1609,22 @@ CmdLineParser::Result CmdLineParser::parseFromArgs(int argc, const char* const a | |||
return Result::Fail; | |||
} | |||
|
|||
// TODO: conflicts with analyzeAllVsConfigs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so as far as I see this will not be an "official" option to start with.. i.e. not shown in the --help output.. which will make it easier to unify later.
No description provided.