Skip to content

fixed #13793 - added CLI option --{no-}analyze-all-vs-configs #7480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

One of the prerequisites for #7293.

@@ -1605,10 +1609,22 @@ CmdLineParser::Result CmdLineParser::parseFromArgs(int argc, const char* const a
return Result::Fail;
}

// TODO: conflicts with analyzeAllVsConfigs
Copy link
Collaborator Author

@firewave firewave Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have like four different ways to select a Visual Studio configuration from the GUI and CLI. At least the code doing it should be unified (if possible). But something for later after the import/CLI handling has been cleaned up and has better test coverage.

Copy link
Owner

@danmar danmar May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have like four different ways to select a Visual Studio configuration from the GUI and CLI.

ouch

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so as far as I see this will not be an "official" option to start with.. i.e. not shown in the --help output.. which will make it easier to unify later.

@@ -1605,10 +1609,22 @@ CmdLineParser::Result CmdLineParser::parseFromArgs(int argc, const char* const a
return Result::Fail;
}

// TODO: conflicts with analyzeAllVsConfigs
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so as far as I see this will not be an "official" option to start with.. i.e. not shown in the --help output.. which will make it easier to unify later.

@firewave firewave merged commit 3d59c29 into danmar:main May 6, 2025
53 checks passed
@firewave firewave deleted the analyze-vs-all-x branch May 6, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants