Skip to content

Commit 3f1913f

Browse files
committed
update local getregion funcs
1 parent c56d81e commit 3f1913f

File tree

2 files changed

+6
-33
lines changed

2 files changed

+6
-33
lines changed

iterative/azure/provider.go

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ import (
88
"strings"
99
"time"
1010

11+
"terraform-provider-iterative/iterative/utils"
12+
1113
"github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2020-06-30/compute"
1214
"github.com/Azure/azure-sdk-for-go/services/network/mgmt/2019-11-01/network"
1315
"github.com/Azure/azure-sdk-for-go/services/resources/mgmt/2020-06-01/resources"
@@ -18,7 +20,7 @@ import (
1820
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
1921
)
2022

21-
//ResourceMachineCreate creates AWS instance
23+
//ResourceMachineCreate creates Azure instance
2224
func ResourceMachineCreate(ctx context.Context, d *schema.ResourceData, m interface{}) error {
2325
subscriptionID, err := subscriptionID()
2426
if err != nil {
@@ -27,7 +29,7 @@ func ResourceMachineCreate(ctx context.Context, d *schema.ResourceData, m interf
2729

2830
username := "ubuntu"
2931
customData := d.Get("startup_script").(string)
30-
region := GetRegion(d.Get("region").(string))
32+
region := utils.GetRegion(d)
3133
instanceType := getInstanceType(d.Get("instance_type").(string), d.Get("instance_gpu").(string))
3234
keyPublic := d.Get("ssh_public").(string)
3335
hddSize := int32(d.Get("instance_hdd_size").(int))
@@ -360,21 +362,6 @@ func getVMClient(subscriptionID string) (compute.VirtualMachinesClient, error) {
360362
return client, err
361363
}
362364

363-
//GetRegion maps region to real cloud regions
364-
func GetRegion(region string) string {
365-
instanceRegions := make(map[string]string)
366-
instanceRegions["us-east"] = "eastus"
367-
instanceRegions["us-west"] = "westus2"
368-
instanceRegions["eu-north"] = "northeurope"
369-
instanceRegions["eu-west"] = "westeurope"
370-
371-
if val, ok := instanceRegions[region]; ok {
372-
return val
373-
}
374-
375-
return region
376-
}
377-
378365
func getInstanceType(instanceType string, instanceGPU string) string {
379366
instanceTypes := make(map[string]string)
380367
instanceTypes["m"] = "Standard_F8s_v2"

iterative/gcp/provider.go

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ func ResourceMachineCreate(ctx context.Context, d *schema.ResourceData, m interf
3131

3232
networkName := "iterative"
3333
instanceName := d.Get("name").(string)
34-
instanceZone := getRegion(d.Get("region").(string))
34+
instanceZone := utils.GetRegion(d)
3535
instanceHddSize := int64(d.Get("instance_hdd_size").(int))
3636
instancePublicSshKey := fmt.Sprintf("%s:%s %s\n", "ubuntu", strings.TrimSpace(d.Get("ssh_public").(string)), "ubuntu")
3737
instanceServiceAccount := d.Get("instance_permission_set").(string)
@@ -277,7 +277,7 @@ func ResourceMachineDelete(ctx context.Context, d *schema.ResourceData, m interf
277277
return err
278278
}
279279

280-
instanceZone := getRegion(d.Get("region").(string))
280+
instanceZone := utils.GetRegion(d)
281281
instanceName := d.Get("name").(string)
282282

283283
service.Instances.Delete(project, instanceZone, instanceName).Do()
@@ -343,20 +343,6 @@ func waitForOperation(ctx context.Context, timeout time.Duration, function func(
343343
return result, err
344344
}
345345

346-
func getRegion(region string) string {
347-
instanceRegions := make(map[string]string)
348-
instanceRegions["us-east"] = "us-east1-c"
349-
instanceRegions["us-west"] = "us-west1-b"
350-
instanceRegions["eu-north"] = "europe-north1-a"
351-
instanceRegions["eu-west"] = "europe-west1-d"
352-
353-
if val, ok := instanceRegions[region]; ok {
354-
return val
355-
}
356-
357-
return region
358-
}
359-
360346
func getInstanceType(instanceType string, instanceGPU string) (map[string]map[string]string, error) {
361347
instanceTypes := make(map[string]map[string]map[string]string)
362348
instanceTypes["m"] = map[string]map[string]string{

0 commit comments

Comments
 (0)