feat: new getItem() signature #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrilletuzi
added a commit
that referenced
this pull request
May 28, 2019
* feat: new JSONSchema, and shortcuts and auto-inference for basic types * feat: disallow null or undefined in setItem * feat: allow custom indexeddb database and store names (#78) * feat: better error management and move idb fallback to main service * internal: reduce surface api * fix: stringify all keys for interoperability * fix: better error management * feat: new getItem() signature (#79) * fix: catch stringify error * fix: catch quota error on localStorage setItem * fix: catch missing store error * fix: remove getUnsafeItem() * feat: new IDB storing behavior with no wrapping (#82) * feat: new prefix token for interop * feat: removeItem when storing null or undefined (#93) * feat: remove xSubscribe() methods (#96) * feat: separate localStorage and Map APIs (#100) * feat: iterating keys() * fix: deprecate xSubscribe * feat: rxjs 6.4 as minimum * fix: use openKeyCursor() when possible for perf * feat: schema option in set() * fix: throw when storing data that can't be serialized in localStorage (#104) * feat: engine and database info + opt-in for unwraped values in idb + new options system (#107) * fix: new interface for new options system * fix: test and doc about blob refused in idb in safari private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify
getItem()signature, which finally allows a correct IntelliSense.Old API is still supported.