-
-
Notifications
You must be signed in to change notification settings - Fork 69
feat: new JSONSchema and auto-inference for basic types #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed as it's merged in v8beta branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64.
Simplify validation by:
JSONSchema
type, to avoid all the TypeScript issues that arised in v7Includes breaking changes:
For numbers:
JSONSchemaNumeric
in favor ofJSONSchemaNumber
andJSONSchemaInteger
For constants:
JSONSchemaConst
const
is now part ofJSONSchemaBoolean
,JSONSchemaNumber
,JSONSchemaInteger
andJSONSchemaString
type
is now requiredFor enums:
JSONSchemaEnum
enum
is now part ofJSONSchemaNumber
,JSONSchemaInteger
andJSONSchemaString
type
is now requiredFor arrays:
type: 'array'
is now requireditems
no longer accepts an array of JSON schemasFor objects:
type: 'object'
is now requiredRemoves
JSONSchemaNull
(makes no sense and can cause interoperability issues)Unsupported properties of the JSON schema standard are no longer accepted.