extract cloud env to a constant

Author: ryanthemanuel

packages/server/lib/StudioLifecycleManager.ts

@@ -12,6 +12,7 @@ import { CloudRequest } from './cloud/api/cloud_request'
 import { isRetryableError } from './cloud/network/is_retryable_error'
 import { asyncRetry } from './util/async_retry'
 import { postStudioSession } from './cloud/api/studio/post_studio_session'
+import { CLOUD_ENV } from './cloud/constants'
 
 const debug = Debug('cypress:server:studio-lifecycle-manager')
 const routes = require('./cloud/routes')
@@ -52,8 +53,7 @@ export class StudioLifecycleManager {
     }).catch(async (error) => {
       debug('Error during studio manager setup: %o', error)
 
-      const cloudEnv = (process.env.CYPRESS_CONFIG_ENV || process.env.CYPRESS_INTERNAL_ENV || 'production') as 'development' | 'staging' | 'production'
-      const cloudUrl = ctx.cloud.getCloudUrl(cloudEnv)
+      const cloudUrl = ctx.cloud.getCloudUrl(CLOUD_ENV)
       const cloudHeaders = await ctx.cloud.additionalHeaders()
 
       reportStudioError({

packages/server/lib/cloud/api/studio/get_and_initialize_studio_manager.ts

@@ -10,7 +10,7 @@ import fetch from 'cross-fetch'
 import { agent } from '@packages/network'
 import { asyncRetry, linearDelay } from '../../../util/async_retry'
 import { isRetryableError } from '../../network/is_retryable_error'
-import { PUBLIC_KEY_VERSION } from '../../constants'
+import { CLOUD_ENV, PUBLIC_KEY_VERSION } from '../../constants'
 import { CloudRequest } from '../cloud_request'
 import type { CloudDataSource } from '@packages/data-context/src/sources'
 
@@ -125,8 +125,7 @@ export const retrieveAndExtractStudioBundle = async ({ studioUrl, projectId }: O
 export const getAndInitializeStudioManager = async ({ studioUrl, projectId, cloudDataSource }: { studioUrl: string, projectId?: string, cloudDataSource: CloudDataSource }): Promise<StudioManager> => {
   let script: string
 
-  const cloudEnv = (process.env.CYPRESS_CONFIG_ENV || process.env.CYPRESS_INTERNAL_ENV || 'production') as 'development' | 'staging' | 'production'
-  const cloudUrl = cloudDataSource.getCloudUrl(cloudEnv)
+  const cloudUrl = cloudDataSource.getCloudUrl(CLOUD_ENV)
   const cloudHeaders = await cloudDataSource.additionalHeaders()
 
   let studioHash: string | undefined

packages/server/lib/cloud/constants.ts

@@ -1 +1,3 @@
 export const PUBLIC_KEY_VERSION = '1'
+
+export const CLOUD_ENV = (process.env.CYPRESS_CONFIG_ENV || process.env.CYPRESS_INTERNAL_ENV || 'production') as 'development' | 'staging' | 'production'

packages/server/lib/project-base.ts

@@ -29,6 +29,7 @@ import { reportStudioError } from './cloud/api/studio/report_studio_error'
 import { CloudRequest } from './cloud/api/cloud_request'
 import { isRetryableError } from './cloud/network/is_retryable_error'
 import { asyncRetry } from './util/async_retry'
+import { CLOUD_ENV } from './cloud/constants'
 
 export interface Cfg extends ReceivedCypressOptions {
   projectId?: string
@@ -407,8 +408,7 @@ export class ProjectBase extends EE {
 
         if (!isStudioReady) {
           debug('User entered studio mode before cloud studio was initialized')
-          const cloudEnv = (process.env.CYPRESS_CONFIG_ENV || process.env.CYPRESS_INTERNAL_ENV || 'production') as 'development' | 'staging' | 'production'
-          const cloudUrl = this.ctx.cloud.getCloudUrl(cloudEnv)
+          const cloudUrl = this.ctx.cloud.getCloudUrl(CLOUD_ENV)
           const cloudHeaders = await this.ctx.cloud.additionalHeaders()
 
           reportStudioError({