perf: optimize parseCspHeaders (#29887)

Connormiha · jennifer-shehane · web-flow · commit 82601500b618 · 2024-07-26T15:23:51.000-04:00
* fix: optimize parseCspHeaders

* Added changelog notes

* Fix changelog

---------

Co-authored-by: Jennifer Shehane &lt;jennifer@cypress.io&gt;
diff --git a/cli/CHANGELOG.md b/cli/CHANGELOG.md
@@ -3,6 +3,10 @@
 
 _Released 7/30/2024 (PENDING)_
 
+**Performance:**
+
+- Improved performance of `reduce` in a method within our proxy. Addressed in [#29887](https://github.com/cypress-io/cypress/pull/29887).
+
 **Bugfixes:**
 
 - Fixed an issue where yarn PnP was not working correctly with Cypress and `@cypress/webpack-batteries-included-preprocessor`. Fixes [#27947](https://github.com/cypress-io/cypress/issues/27947).
diff --git a/packages/proxy/lib/http/util/csp-header.ts b/packages/proxy/lib/http/util/csp-header.ts
@@ -107,7 +107,9 @@ export function parseCspHeaders (headers: OutgoingHttpHeaders, headerName: strin
       policy = cspRegExp.exec(cspHeader)
     }
 
-    return [...acc, policies]
+    acc.push(policies)
+
+    return acc
   }, [])
 }
 

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,9 @@ export function parseCspHeaders (headers: OutgoingHttpHeaders, headerName: strin`
`107`	`107`	`policy = cspRegExp.exec(cspHeader)`
`108`	`108`	`}`
`109`	`109`
`110`		`- return [...acc, policies]`
	`110`	`+ acc.push(policies)`
	`111`	`+`
	`112`	`+ return acc`
`111`	`113`	`}, [])`
`112`	`114`	`}`
`113`	`115`