Skip to content

Fix "cy.visit() succeeded, but commands are timing out" error example #6157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

MikeMcC399
Copy link
Contributor

Status

https://on.cypress.io/cy-visit-succeeded-but-commands-fail forwards to the documentation page

cy.visit() succeeded, but commands are timing out

where a failing example is given, visiting the following domains:

it('navigates to docs.cypress.io and runs additional commands', () => {
  cy.visit('http://localhost:3000')
  cy.visit('https://docs.cypress.io') // visit a different superdomain
  cy.get('h1').should('contain', 'Why Cypress?') // fails
})

The solution is given as:

it('navigates to example.cypress.io and runs additional commands', () => {
  cy.visit('http://localhost:3000')
  cy.visit('https://example.cypress.io') // visit a different superdomain
  cy.origin('https://example.cypress.io', () => {
    cy.get('h1').should('contain', 'Why Cypress?') // now succeeds!
  })
})

This is confusing because, without explanation, the secondary domain example.cypress.io in the solution differs from the secondary domain docs.cypress.io in the failing test spec.

Furthermore, since only https://docs.cypress.io contains a 'Why Cypress?', not https://example.cypress.io, the corrected example will fail if an attempt is made to run it.

The text refers to superdomain, however the Cypress 14 Migration Guide explains that tests must be in the same domain. Being in the same superdomain is no longer sufficient.

Change

  1. Modify the solution in https://docs.cypress.io/app/references/error-messages#cyvisit-succeeded-but-commands-are-timing-out to use https://docs.cypress.io instead of https://example.cypress.io

    it('navigates to docs.cypress.io and runs additional commands', () => {
      cy.visit('http://localhost:3000')
      cy.visit('https://docs.cypress.io') // visit a different domain
      cy.origin('https://docs.cypress.io', () => {
        cy.get('h1').should('contain', 'Why Cypress?') // now succeeds!
      })
    })
  2. Change "superdomain" to "domain" in the text

Verify

git clone --branch test/origin https://github.com/MikeMcC399/cypress-documentation
cd cypress-documentation
npm ci
npm start

In a separate terminal window, execute:

npx cypress run -s cypress/e2e/visit-timeout-correction.cy.ts

Copy link

netlify bot commented Apr 22, 2025

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f82f5a4

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399

This comment was marked as outdated.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jennifer-shehane jennifer-shehane merged commit 6c0869c into cypress-io:main Apr 22, 2025
7 checks passed
@MikeMcC399 MikeMcC399 deleted the visit-timout-origin branch April 23, 2025 04:51
jennifer-shehane added a commit that referenced this pull request May 8, 2025
* Add Windows 2025 to supported OS list (#6142)

* New user roles and permissions defined (#6143)

* chore: release 14.3.0 documentation (#6144)

* feat: documentation for the press() command (#6135)

* docs for the press() command, including a callout in the accessibility guide

* add press to TOC

* Move some content around, mention accesiibility

* remove 'focus' note

* Document Keyboard.Keys

* update reference to command

* Update example to be a little more real case

* Add another example of autocomplete with tab

* Add link to keyboard api page

* Fix version number for introduction

* Fix broken link

* alphabetize see also

* Update package.json

Co-authored-by: Mike McCready <[email protected]>

* Fix broken link

* lint

---------

Co-authored-by: Jennifer Shehane <[email protected]>
Co-authored-by: Mike McCready <[email protected]>

* chore: add 14.3.0 changelog to documentation

* Update docs/app/guides/accessibility-testing.mdx

* Update docs/app/references/changelog.mdx

Co-authored-by: Bill Glesias <[email protected]>

---------

Co-authored-by: Cacie Prins <[email protected]>
Co-authored-by: Jennifer Shehane <[email protected]>
Co-authored-by: Mike McCready <[email protected]>

* Correct parameter usage for click() in shadow.mdx (#6145)

* Update shadow.mdx

- Update the suggestion to pass 'top' to cy.click() using the options defined in cy.click()'s documentation

* Update shadow.mdx

Add missing quote

* Update shadow.mdx

One-line for prettier reasons

* Correct command syntax (#6148)

Adds the missing `s` to `Cypress.Command.overwrite()`

* extend pnpm config instructions (#6149)

* fix cy.origin() "yielding a value" example (#6152)

* Update results-api.mdx (#6150)

* chore: add 14.3.1 changelog (#6153)

* chore: add 14.3.1 changelog

* Update docs/app/references/changelog.mdx

Co-authored-by: Mike McCready <[email protected]>

* empty commit to rekick build

---------

Co-authored-by: Mike McCready <[email protected]>

* docs: harmonize on injectDocumentDomain removal in future version (#6154)

* Add experimentalSessionAndOrigin removed comment to origin video (#6158)

* Fix "cy.visit() succeeded, but commands are timing out" error example (#6157)

* Cross-link cy.origin and injectDocumentDomain (#6156)

* chore: add cypress 14.3.2 changelog (#6160)

* Change 'add on' to 'premium solution' for UI Cov & a11y products (#6162)

* UI Coverage and Branch Review updates (#6167)

* add AQ links and button space

* use onlinks for demo vids

* update Cypress

* content updates

* content tweaks

* add last images

* lint-fix

* simplify

* add detail view docs and clean up

* lint fix

* Update docs/cloud/get-started/introduction.mdx

Co-authored-by: Mike McCready <[email protected]>

* Update docs/ui-coverage/core-concepts/compare-reports.mdx

Co-authored-by: Mike McCready <[email protected]>

* Update docs/ui-coverage/core-concepts/compare-reports.mdx

Co-authored-by: Mike McCready <[email protected]>

* revert cypress version bump

* restore package-lock

* remove yarn lockfile

* Update docs/app/get-started/why-cypress.mdx

Co-authored-by: Tyler Biethman <[email protected]>

* Update docs/cloud/features/branch-review.mdx

Co-authored-by: Tyler Biethman <[email protected]>

* Update docs/cloud/features/branch-review.mdx

Co-authored-by: Tyler Biethman <[email protected]>

---------

Co-authored-by: Mike McCready <[email protected]>
Co-authored-by: Tyler Biethman <[email protected]>

* chore: add 14.3.3 changelog (#6171)

* chore: add 14.3.3 changelog

* Update docs/app/references/changelog.mdx

Co-authored-by: Matt Schile <[email protected]>

---------

Co-authored-by: Matt Schile <[email protected]>

* Rework instructions for missing Cypress binary in CI (#6170)

* Node.js 18 EOL (#6165)

* Add quoting advice for PowerShell CLI options (#6169)

* Add quoting advice for PowerShell CLI options

* Fix --config typo

Co-authored-by: Jennifer Shehane <[email protected]>

---------

Co-authored-by: Jennifer Shehane <[email protected]>

* Bump Cypress Docker versions in examples to Node.js 22.15.0 LTS (#6161)

---------

Co-authored-by: Mike McCready <[email protected]>
Co-authored-by: danjohansenconsulting <[email protected]>
Co-authored-by: Cacie Prins <[email protected]>
Co-authored-by: Jennifer Shehane <[email protected]>
Co-authored-by: Matthew Sbar <[email protected]>
Co-authored-by: Tim Rayers <[email protected]>
Co-authored-by: Emily Wisniewski (Rohrbough) <[email protected]>
Co-authored-by: Mark Noonan <[email protected]>
Co-authored-by: Tyler Biethman <[email protected]>
Co-authored-by: Matt Schile <[email protected]>
Co-authored-by: Jennifer Shehane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants