Skip to content

Set github-action examples to ubuntu-22.04 #5154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Set github-action examples to ubuntu-22.04 #5154

merged 3 commits into from
Apr 11, 2023

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Mar 30, 2023

This PR aligns the Guides > Continuous Integration > Github Actions page with the repository hosting cypress-io/github-action. It consistently uses ubuntu-22.04 as runner.

The GitHub runner version ubuntu-22.04 is used as default in the README file and examples of the action repository. This default is now carried over to the corresponding documentation page here in this repository.

Previously the GitHub runner ubuntu-20.04 for the corresponding LTS version, released in the year 2020, was being referred to, or ubuntu-latest.

  • ubuntu-20.04 is older, so it makes more sense to use ubuntu-22.04 which has a longer lifetime. According to The Ubuntu lifecycle and release cadence, ubuntu-22.04 will be fully supported for 5 years until April 2027.
  • ubuntu-latest is theoretically problematic because it puts any version switch-over into the hands of GitHub Operations. In general it seems better to specify concrete major versions in examples, rather than latest. (The use of latest, to select the pnpm version to install, broke workflows unexpectedly when pnpm 8.0.0 was released this week, for instance!)

@netlify
Copy link

netlify bot commented Mar 30, 2023

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit aec1b87

@MikeMcC399 MikeMcC399 marked this pull request as ready for review March 30, 2023 14:23
@MikeMcC399
Copy link
Contributor Author

@jaffrepaul
Does anybody else need to approve this before it is merged?

@jaffrepaul
Copy link
Contributor

Nope!

@jaffrepaul jaffrepaul merged commit 55eac7d into cypress-io:main Apr 11, 2023
@MikeMcC399 MikeMcC399 deleted the gha/ubuntu-22 branch April 11, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants