Skip to content

Some clarifications for end users #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2024
Merged

Some clarifications for end users #230

merged 2 commits into from
May 28, 2024

Conversation

rptaylor
Copy link
Contributor

Clarify some points to make it easier to understand for end users.

@rptaylor
Copy link
Contributor Author

@HereThereBeDragons Could you take a look and merge if it looks okay please?

vvolkl
vvolkl approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@vvolkl vvolkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good point about CVMFS_REPOSITORIES! The previous version read as if that was actually mounting the repositories

HereThereBeDragons
HereThereBeDragons reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@HereThereBeDragons HereThereBeDragons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ryan!
just some small additions to add a bit more clarifications. add them if you think they are useful otherwise it is fine with me.

@vvolkl @HereThereBeDragons
Apply suggestions from code review
75579a8 
Co-authored-by: HereThereBeDragons <[email protected]>
@vvolkl
Copy link
Contributor

vvolkl commented May 28, 2024

I'll merge, but will follow up with a PR that moves all mentions of CVMFS_REPOSITORIES to the client configuration section. For the quick start, it's good to keep it brief, and this parameter is honestly a bit confusing.

@vvolkl vvolkl merged commit a4f3eb6 into cvmfs:stable May 28, 2024
@rptaylor rptaylor deleted the patch-17 branch May 28, 2024 19:05
vvolkl added a commit that referenced this pull request May 29, 2024
@rptaylor @vvolkl @HereThereBeDragons
Some clarifications for end users (#230)
9acdf56 
* Some clarifications for end users

* Apply suggestions from code review

Co-authored-by: HereThereBeDragons <[email protected]>

---------

Co-authored-by: Valentin Volkl <[email protected]>
Co-authored-by: HereThereBeDragons <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HereThereBeDragons HereThereBeDragons HereThereBeDragons left review comments

@vvolkl vvolkl vvolkl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rptaylor @vvolkl @HereThereBeDragons