-
-
Notifications
You must be signed in to change notification settings - Fork 88
Add sandbox setup cmd for VSCodium #2989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The only reliable, cross-platform workaround to OpenVSX marketplace not having the vscode-tree-sitter-query plugin I could find was to just bundle it as part of the repository (in I'll add some details to the documentation about this, and then things should be ready for review! |
Required to smoothly show commands for both VSCode and VSCodium when they differ
Should be ready for review! |
Not quite sure I'm following fully. The parse tree extension that Cursorless requires is already available on open vsx. |
|
Oh you mean you are missing a language definition for I'm not a big fan of bundling other extensions like this. Is it really that much of a problem to just install this dependency manually during initial setup for now? Hopefully the extension will be available on the marketplace in the future |
This implicitly requires
vscode-tree-sitter-query
to be published to the Open VSX Registry to not cause issues when running tests, as rn that plugin is commented out inpackages/common/src/extensionDependencies.ts
due to it not being present there. This PR will therefor need to be a draft until that plugin is uploaded to Open VSX; I'll probably also add to the documentation to note the differences in commands between VSCodium and VSCode at some point soon. There's also probably a cleaner way to do this with a variable passed topackages/cursorless-vscode/src/scripts/initLaunchSandbox.ts
to swap between vscode and vscodium mode or something, but I'll look into that later as well.