-
Notifications
You must be signed in to change notification settings - Fork 12
Redesigned report header #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cucumber-react-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
890a17d
to
9bebdd4
Compare
The compression of the search and header is great. Keep that. But the names and version numbers for the OS, platform and implementation are quite useful. Especially if we don't have a logo for the exact software used. For example Req'n Roll on Mono on Alpine. Additionally the cell headers add some noise. That could be compressed a bit more by communicating the meaning implicitly. For example:
Not sure where to put the logos for the implementation, platform and os though. |
Yeah these are available as tooltips on each one but I did suspect that wouldn't be discoverable enough. I might play with an icon/button that pops up the full details. Or slot the text in some other way.
I did experiment with that but found the headers made things generally a bit easier on the eye and easier to read, plus the values tend to get longer and put constraints on horizontal space. I'll try some more though. |
That would be useful. Being able to copy-paste diagnostics like that is really nice. |
d742bbd
to
c5d041d
Compare
fec75fc
to
8f1f219
Compare
🤔 What's changed?
This PR changes the "report header" components to be more compact and better-styled.
Before
After
⚡️ What's your motivation?
The previous header was not very space-efficient and not great aesthetically either. This new header conveys the same information in about half the height and a more cohesive style.
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.