eslint: use standard (#1022)

Author: charlierudolph

.eslintrc.yml

@@ -3,7 +3,7 @@ env:
   es6: true
   node: true
 extends:
-  - 'eslint:recommended'
+  - standard
   - prettier
 globals:
   afterEach: false
@@ -20,17 +20,6 @@ plugins:
   - babel
   - prettier
 rules:
-  babel/new-cap: error
-  complexity: error
-  eqeqeq: [error, always]
-  no-await-in-loop: error
-  no-negated-condition: error
-  no-nested-ternary: error
-  no-plusplus: error
-  no-shadow: error
-  no-unneeded-ternary: [error, {defaultAssignment: false}]
-  no-var: error
-  object-shorthand: [error, always]
   prettier/prettier:
     - error
     - trailingComma: none

dependency-lint.yml

@@ -36,8 +36,13 @@ ignoreErrors:
     - coffee-script # features/compiler.feature
     - coveralls # .travis.yml
     - eslint-config-prettier # .eslintrc.yml - extends
+    - eslint-config-standard # .eslintrc.yml - extends
     - eslint-plugin-babel # .eslintrc.yml - parser
+    - eslint-plugin-import # peer dependency of eslint-config-standard
+    - eslint-plugin-node # peer dependency of eslint-config-standard
     - eslint-plugin-prettier # .eslintrc.yml - plugins
+    - eslint-plugin-promise # peer dependency of eslint-config-standard
+    - eslint-plugin-standard # peer dependency of eslint-config-standard
     - prettier # peer dependency of eslint-plugin-prettier
 
 requiredModules:

example/index.js

@@ -13,7 +13,7 @@ function runFeature() {
     eventBroadcaster
   )
 
-  let featureSource = featureEditor.getValue()
+  const featureSource = featureEditor.getValue()
   const testCases = Cucumber.getTestCases({
     eventBroadcaster,
     pickleFilter: new Cucumber.PickleFilter({}),
@@ -22,10 +22,10 @@ function runFeature() {
   })
 
   Cucumber.supportCodeLibraryBuilder.reset('')
-  new Function(stepDefinitionsEditor.getValue())()
-  let supportCodeLibrary = Cucumber.supportCodeLibraryBuilder.finalize()
+  new Function(stepDefinitionsEditor.getValue())() // eslint-disable-line no-new-func
+  const supportCodeLibrary = Cucumber.supportCodeLibraryBuilder.finalize()
 
-  let formatterOptions = {
+  const formatterOptions = {
     colorsEnabled: true,
     cwd: '/',
     eventBroadcaster,
@@ -37,7 +37,7 @@ function runFeature() {
   }
   Cucumber.FormatterBuilder.build('progress', formatterOptions)
 
-  let runtime = new Cucumber.Runtime({
+  const runtime = new Cucumber.Runtime({
     eventBroadcaster,
     options: {},
     testCases,
@@ -52,12 +52,12 @@ function appendToOutput(data) {
 }
 
 function displayError(error) {
-  let errorContainer = $('<div>')
+  const errorContainer = $('<div>')
   errorContainer.addClass('error').text(error.stack || error)
   appendToOutput(errorContainer)
 }
 
-$(function() {
+$(() => {
   featureEditor = ace.edit('feature')
   featureEditor.getSession().setMode('ace/mode/gherkin')
 
@@ -68,14 +68,14 @@ $(function() {
 
   window.onerror = displayError
 
-  $('#run-feature').click(function() {
+  $('#run-feature').click(() => {
     runFeature()
-      .then(function(success) {
-        let exitStatus = success ? '0' : '1'
-        let exitStatusContainer = $('<div>')
+      .then(success => {
+        const exitStatus = success ? '0' : '1'
+        const exitStatusContainer = $('<div>')
         exitStatusContainer
           .addClass('exit-status')
-          .text('Exit Status: ' + exitStatus)
+          .text(`Exit Status: ${exitStatus}`)
         appendToOutput(exitStatusContainer)
       })
       .catch(displayError)

features/step_definitions/cli_steps.js

@@ -20,13 +20,12 @@ When(
   function(location) {
     if (location === 'locally') {
       return this.run(this.localExecutablePath, [])
-    } else {
-      return this.run(this.globalExecutablePath, [])
     }
+    return this.run(this.globalExecutablePath, [])
   }
 )
 
-Then(/^it passes$/, function() {})
+Then(/^it passes$/, () => {})
 
 Then(/^it fails$/, function() {
   const actualCode = this.lastRun.error ? this.lastRun.error.code : 0
@@ -69,7 +68,7 @@ Then(/^the error output contains the text:$/, function(text) {
 Then(/^I see the version of Cucumber$/, function() {
   const version = require('../../package.json').version
   const actualOutput = this.lastRun.output
-  const expectedOutput = version + '\n'
+  const expectedOutput = `${version}\n`
   expect(actualOutput).to.eql(expectedOutput)
 })
 

features/step_definitions/file_steps.js

@@ -29,7 +29,7 @@ Given(/^a directory named "(.*)"$/, function(filePath) {
 
 Given(/^"([^"]*)" is an absolute path$/, function(filePath) {
   filePath = Mustache.render(filePath, this)
-  expect(path.isAbsolute(filePath)).to.be.true
+  expect(path.isAbsolute(filePath)).to.eql(true)
 })
 
 Then(/^the file "([^"]*)" has the text:$/, async function(filePath, text) {

features/step_definitions/json_output_steps.js

@@ -36,9 +36,9 @@ Then(/^the scenario "([^"]*)" has the steps$/, function(name, table) {
     scenarioPredicate: ['name', name]
   })
   const expectedNames = table.rows().map(row => row[0])
-  const actualNames = scenario.steps.map(function(step) {
-    return _.compact([step.keyword, step.name]).join('')
-  })
+  const actualNames = scenario.steps.map(step =>
+    _.compact([step.keyword, step.name]).join('')
+  )
   expect(actualNames).to.eql(expectedNames)
 })
 
@@ -109,9 +109,7 @@ Then(/^the (first|second) scenario has the steps$/, function(cardinal, table) {
     features: this.lastRun.jsonOutput,
     scenarioPredicate: (element, index) => index === scenarioIndex
   })
-  const stepNames = scenario.steps.map(function(step) {
-    return [step.name]
-  })
+  const stepNames = scenario.steps.map(step => [step.name])
   expect(stepNames).to.eql(table.rows())
 })
 
@@ -141,9 +139,7 @@ Then(
       },
       stepPredicate: ['name', name]
     })
-    const expected = table.raw().map(function(row) {
-      return { cells: row }
-    })
+    const expected = table.raw().map(row => ({ cells: row }))
     expect(step.arguments[0].rows).to.eql(expected)
   }
 )

features/step_definitions/usage_json_steps.js

@@ -8,12 +8,10 @@ import path from 'path'
 Then('it outputs the usage data:', function(table) {
   const usageData = JSON.parse(this.lastRun.output)
   table.hashes().forEach(row => {
-    const rowUsage = _.find(usageData, datum => {
-      return datum.pattern === row['PATTERN']
-    })
-    expect(rowUsage).to.exist
-    expect(rowUsage.line).to.eql(parseInt(row['LINE']))
+    const rowUsage = _.find(usageData, datum => datum.pattern === row.PATTERN)
+    expect(rowUsage).to.be.an('object')
+    expect(rowUsage.line).to.eql(parseInt(row.LINE))
     expect(rowUsage.matches).to.have.lengthOf(row['NUMBER OF MATCHES'])
-    expect(rowUsage.uri).to.eql(path.normalize(row['URI']))
+    expect(rowUsage.uri).to.eql(path.normalize(row.URI))
   })
 })

features/support/event_protocol_output_helpers.js

@@ -3,7 +3,8 @@ import path from 'path'
 export function normalizeEventProtocolOutput(str) {
   return str
     .replace(/"duration":\d*/g, '"duration":0')
-    .replace(/"uri":"([^"]*)"/g, (match, uri) => {
-      return `"uri":"${path.normalize(uri)}"`
-    })
+    .replace(
+      /"uri":"([^"]*)"/g,
+      (match, uri) => `"uri":"${path.normalize(uri)}"`
+    )
 }

features/support/hooks.js

@@ -89,11 +89,8 @@ Before('@global-install', function() {
 After(function() {
   if (this.lastRun.error && !this.verifiedLastRunError) {
     throw new Error(
-      'Last run errored unexpectedly. Output:\n\n' +
-        this.lastRun.output +
-        '\n\n' +
-        'Error Output:\n\n' +
-        this.lastRun.errorOutput
+      `Last run errored unexpectedly. Output:\n\n${this.lastRun.output}\n\n` +
+        `Error Output:\n\n${this.lastRun.errorOutput}`
     )
   }
 })

features/support/json_output_helpers.js

@@ -26,9 +26,8 @@ export function findScenario({ features, scenarioPredicate }) {
     .value()
   if (scenario) {
     return scenario
-  } else {
-    throw new Error('Could not find scenario matching predicate')
   }
+  throw new Error('Could not find scenario matching predicate')
 }
 
 export function findStep({ features, stepPredicate, scenarioPredicate }) {
@@ -46,17 +45,16 @@ export function findStep({ features, stepPredicate, scenarioPredicate }) {
   const step = _.find(steps, stepPredicate)
   if (step) {
     return step
-  } else {
-    throw new Error(
-      `Could not find step matching predicate: ${util.inspect(features, {
-        depth: null
-      })}`
-    )
   }
+  throw new Error(
+    `Could not find step matching predicate: ${util.inspect(features, {
+      depth: null
+    })}`
+  )
 }
 
 export function neutraliseVariableValues(report) {
-  report.forEach(function(item) {
+  report.forEach(item => {
     ;(item.elements || []).forEach(element => {
       ;(element.steps || []).forEach(step => {
         if ('result' in step) {