Skip to content

Commit ee9d552

Browse files
Christoph Hellwigaxboe
authored andcommitted
blk-mq: simplify blk_mq_realloc_tag_set_tags
Use set->nr_hw_queues for the current number of tags, and remove the duplicate set->nr_hw_queues update in the caller. Signed-off-by: Christoph Hellwig <[email protected]> Reviewed-by: Chaitanya Kulkarni <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
1 parent 5ee2029 commit ee9d552

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

block/blk-mq.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4376,11 +4376,11 @@ static void blk_mq_update_queue_map(struct blk_mq_tag_set *set)
43764376
}
43774377

43784378
static int blk_mq_realloc_tag_set_tags(struct blk_mq_tag_set *set,
4379-
int cur_nr_hw_queues, int new_nr_hw_queues)
4379+
int new_nr_hw_queues)
43804380
{
43814381
struct blk_mq_tags **new_tags;
43824382

4383-
if (cur_nr_hw_queues >= new_nr_hw_queues)
4383+
if (set->nr_hw_queues >= new_nr_hw_queues)
43844384
return 0;
43854385

43864386
new_tags = kcalloc_node(new_nr_hw_queues, sizeof(struct blk_mq_tags *),
@@ -4389,7 +4389,7 @@ static int blk_mq_realloc_tag_set_tags(struct blk_mq_tag_set *set,
43894389
return -ENOMEM;
43904390

43914391
if (set->tags)
4392-
memcpy(new_tags, set->tags, cur_nr_hw_queues *
4392+
memcpy(new_tags, set->tags, set->nr_hw_queues *
43934393
sizeof(*set->tags));
43944394
kfree(set->tags);
43954395
set->tags = new_tags;
@@ -4705,11 +4705,9 @@ static void __blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set,
47054705
}
47064706

47074707
prev_nr_hw_queues = set->nr_hw_queues;
4708-
if (blk_mq_realloc_tag_set_tags(set, set->nr_hw_queues, nr_hw_queues) <
4709-
0)
4708+
if (blk_mq_realloc_tag_set_tags(set, nr_hw_queues) < 0)
47104709
goto reregister;
47114710

4712-
set->nr_hw_queues = nr_hw_queues;
47134711
fallback:
47144712
blk_mq_update_queue_map(set);
47154713
list_for_each_entry(q, &set->tag_list, tag_set_list) {

0 commit comments

Comments
 (0)