Skip to content

Commit dd5a927

Browse files
amir73ilSteve French
authored andcommitted
cifs: fix set of group SID via NTSD xattrs
'setcifsacl -g <SID>' silently fails to set the group SID on server. Actually, the bug existed since commit 438471b ("CIFS: Add support for setting owner info, dos attributes, and create time"), but this fix will not apply cleanly to kernel versions <= v5.10. Fixes: 3970acf ("SMB3: Add support for getting and setting SACLs") Cc: [email protected] # 5.11+ Signed-off-by: Amir Goldstein <[email protected]> Signed-off-by: Steve French <[email protected]>
1 parent 9405b5f commit dd5a927

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

fs/cifs/xattr.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,11 +175,13 @@ static int cifs_xattr_set(const struct xattr_handler *handler,
175175
switch (handler->flags) {
176176
case XATTR_CIFS_NTSD_FULL:
177177
aclflags = (CIFS_ACL_OWNER |
178+
CIFS_ACL_GROUP |
178179
CIFS_ACL_DACL |
179180
CIFS_ACL_SACL);
180181
break;
181182
case XATTR_CIFS_NTSD:
182183
aclflags = (CIFS_ACL_OWNER |
184+
CIFS_ACL_GROUP |
183185
CIFS_ACL_DACL);
184186
break;
185187
case XATTR_CIFS_ACL:

0 commit comments

Comments
 (0)