Skip to content

Commit b011893

Browse files
author
Andreas Gruenbacher
committed
gfs2: Don't forget to complete delayed withdraw
Commit fffe9be ("gfs2: Delay withdraw from atomic context") switched from gfs2_withdraw() to gfs2_withdraw_delayed() in gfs2_ail_error(), but failed to then check if a delayed withdraw had occurred. Fix that by adding the missing check in __gfs2_ail_flush(), where the spin locks are already dropped and a withdraw is possible. Fixes: fffe9be ("gfs2: Delay withdraw from atomic context") Signed-off-by: Andreas Gruenbacher <[email protected]>
1 parent 3592bfa commit b011893

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

fs/gfs2/glops.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,9 @@ static void __gfs2_ail_flush(struct gfs2_glock *gl, bool fsync,
8282
GLOCK_BUG_ON(gl, !fsync && atomic_read(&gl->gl_ail_count));
8383
spin_unlock(&sdp->sd_ail_lock);
8484
gfs2_log_unlock(sdp);
85+
86+
if (gfs2_withdrawing(sdp))
87+
gfs2_withdraw(sdp);
8588
}
8689

8790

0 commit comments

Comments
 (0)