Skip to content

Commit 9f3fa6b

Browse files
mngyadamherbertx
authored andcommitted
KEYS: use kfree_sensitive with key
key might contain private part of the key, so better use kfree_sensitive to free it Signed-off-by: Mahmoud Adam <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
1 parent e22471c commit 9f3fa6b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

crypto/asymmetric_keys/public_key.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ static void public_key_describe(const struct key *asymmetric_key,
4242
void public_key_free(struct public_key *key)
4343
{
4444
if (key) {
45-
kfree(key->key);
45+
kfree_sensitive(key->key);
4646
kfree(key->params);
4747
kfree(key);
4848
}
@@ -263,7 +263,7 @@ static int software_key_query(const struct kernel_pkey_params *params,
263263
else
264264
crypto_free_akcipher(tfm);
265265
error_free_key:
266-
kfree(key);
266+
kfree_sensitive(key);
267267
pr_devel("<==%s() = %d\n", __func__, ret);
268268
return ret;
269269
}
@@ -369,7 +369,7 @@ static int software_key_eds_op(struct kernel_pkey_params *params,
369369
else
370370
crypto_free_akcipher(tfm);
371371
error_free_key:
372-
kfree(key);
372+
kfree_sensitive(key);
373373
pr_devel("<==%s() = %d\n", __func__, ret);
374374
return ret;
375375
}
@@ -441,7 +441,7 @@ int public_key_verify_signature(const struct public_key *pkey,
441441
sig->digest, sig->digest_size);
442442

443443
error_free_key:
444-
kfree(key);
444+
kfree_sensitive(key);
445445
error_free_tfm:
446446
crypto_free_sig(tfm);
447447
pr_devel("<==%s() = %d\n", __func__, ret);

0 commit comments

Comments
 (0)