netfilter: nf_tables: fix percpu memory leak at nf_tables_addchain()

Tetsuo Handa · Florian Westphal · commit 9a4d6dd554b8 · 2022-09-20T23:50:03.000+02:00
It seems to me that percpu memory for chain stats started leaking since commit 3bc158f ("netfilter: nf_tables: map basechain priority to hardware priority") when nft_chain_offload_priority() returned an error. Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Fixes: 3bc158f ("netfilter: nf_tables: map basechain priority to hardware priority") Signed-off-by: Florian Westphal <fw@strlen.de>
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
@@ -2243,6 +2243,7 @@ static int nf_tables_addchain(struct nft_ctx *ctx, u8 family, u8 genmask,
 		if (err < 0) {
 			nft_chain_release_hook(&hook);
 			kfree(basechain);
+			free_percpu(stats);
 			return err;
 		}
 		if (stats)

Original file line number	Diff line number	Diff line change
`@@ -2243,6 +2243,7 @@ static int nf_tables_addchain(struct nft_ctx *ctx, u8 family, u8 genmask,`
`2243`	`2243`	`if (err < 0) {`
`2244`	`2244`	`nft_chain_release_hook(&hook);`
`2245`	`2245`	`kfree(basechain);`
	`2246`	`+ free_percpu(stats);`
`2246`	`2247`	`return err;`
`2247`	`2248`	`}`
`2248`	`2249`	`if (stats)`