Skip to content

Commit 4d3f59b

Browse files
pkitszelanguy11
authored andcommitted
ice: split ice_init_hw() out from ice_init_dev()
Split ice_init_hw() call out from ice_init_dev(). Such move enables pulling the former to be even earlier on call path, what would enable moving ice_adapter init to be between the two (in subsequent commit). Such move enables ice_adapter to know about number of PFs. Do the same for ice_deinit_hw(), so the init and deinit calls could be easily mirrored. Next commit will rename unrelated goto labels to unroll prefix. Reviewed-by: Marcin Szycik <[email protected]> Signed-off-by: Przemek Kitszel <[email protected]> Reviewed-by: Kalesh AP <[email protected]> Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <[email protected]>
1 parent c37dd67 commit 4d3f59b

File tree

2 files changed

+20
-12
lines changed

2 files changed

+20
-12
lines changed

drivers/net/ethernet/intel/ice/devlink/devlink.c

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1207,9 +1207,15 @@ static int ice_devlink_reinit_up(struct ice_pf *pf)
12071207
struct ice_vsi *vsi = ice_get_main_vsi(pf);
12081208
int err;
12091209

1210+
err = ice_init_hw(&pf->hw);
1211+
if (err) {
1212+
dev_err(ice_pf_to_dev(pf), "ice_init_hw failed: %d\n", err);
1213+
return err;
1214+
}
1215+
12101216
err = ice_init_dev(pf);
12111217
if (err)
1212-
return err;
1218+
goto unroll_hw_init;
12131219

12141220
vsi->flags = ICE_VSI_FLAG_INIT;
12151221

@@ -1232,6 +1238,8 @@ static int ice_devlink_reinit_up(struct ice_pf *pf)
12321238
rtnl_unlock();
12331239
err_vsi_cfg:
12341240
ice_deinit_dev(pf);
1241+
unroll_hw_init:
1242+
ice_deinit_hw(&pf->hw);
12351243
return err;
12361244
}
12371245

drivers/net/ethernet/intel/ice/ice_main.c

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4755,12 +4755,6 @@ int ice_init_dev(struct ice_pf *pf)
47554755
struct ice_hw *hw = &pf->hw;
47564756
int err;
47574757

4758-
err = ice_init_hw(hw);
4759-
if (err) {
4760-
dev_err(dev, "ice_init_hw failed: %d\n", err);
4761-
return err;
4762-
}
4763-
47644758
ice_init_feature_support(pf);
47654759

47664760
err = ice_init_ddp_config(hw, pf);
@@ -4781,7 +4775,7 @@ int ice_init_dev(struct ice_pf *pf)
47814775
err = ice_init_pf(pf);
47824776
if (err) {
47834777
dev_err(dev, "ice_init_pf failed: %d\n", err);
4784-
goto err_init_pf;
4778+
return err;
47854779
}
47864780

47874781
pf->hw.udp_tunnel_nic.set_port = ice_udp_tunnel_set_port;
@@ -4825,8 +4819,6 @@ int ice_init_dev(struct ice_pf *pf)
48254819
ice_clear_interrupt_scheme(pf);
48264820
err_init_interrupt_scheme:
48274821
ice_deinit_pf(pf);
4828-
err_init_pf:
4829-
ice_deinit_hw(hw);
48304822
return err;
48314823
}
48324824

@@ -5319,9 +5311,15 @@ ice_probe(struct pci_dev *pdev, const struct pci_device_id __always_unused *ent)
53195311
hw->debug_mask = debug;
53205312
#endif
53215313

5314+
err = ice_init_hw(hw);
5315+
if (err) {
5316+
dev_err(dev, "ice_init_hw failed: %d\n", err);
5317+
goto unroll_adapter;
5318+
}
5319+
53225320
err = ice_init(pf);
53235321
if (err)
5324-
goto err_init;
5322+
goto unroll_hw_init;
53255323

53265324
devl_lock(priv_to_devlink(pf));
53275325
err = ice_load(pf);
@@ -5340,7 +5338,9 @@ ice_probe(struct pci_dev *pdev, const struct pci_device_id __always_unused *ent)
53405338
err_load:
53415339
devl_unlock(priv_to_devlink(pf));
53425340
ice_deinit(pf);
5343-
err_init:
5341+
unroll_hw_init:
5342+
ice_deinit_hw(hw);
5343+
unroll_adapter:
53445344
ice_adapter_put(pdev);
53455345
return err;
53465346
}

0 commit comments

Comments
 (0)