custom-properties : fix how preserve false interacts with duplicate code #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Oct 20, 2022
| @@ -112,12 +112,10 @@ | |||
|
|
|||
| .ignores-declarations-that-have-an-exact-fallback-a { | |||
| left: 1rem; | |||
| left: var(--does-not-exist, 1rem); | |||
There was a problem hiding this comment.
We can not preserve var() because left: 1rem; will never be used by browsers that understand var();
Because we strip the :root of all custom props we also have to remove these.
romainmenke
changed the title
3 tasks
Antonio-Laguna
approved these changes
Oct 20, 2022
romainmenke
force-pushed
the
fix-661--sensible-moose-a2db268650
branch
from
c7f0c35 to
0dfaed5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.