-
Notifications
You must be signed in to change notification settings - Fork 214
update deps, tweaked config, added yarn pkg, and setup distribution w/ docs - 091817 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated to use the latest version of React
…1817 Update package.json
…s. Removed port from package.json script calls
Fixed readme formating
I appreciate your interest in the project. I'll go through the PR in a few days, but as a few initial notes:
It seems you are actively making changes and adding them to the PR. Can you explain your goals a bit? |
I am working getting your fantastic code packaging and distributing with electron-builder.. which is turning into not a small feat. I also have been trying to update and put in more detailed step by step process for this, based on your article. --i updated the request info to reflect my proposed changes |
I suggest you look at this issue. Another user did this, in their own fork. The details are in the referenced issue. |
Thanx for the link i will try to recreate and build using that repo and compare.. i was also able to get a nice build working from this repo . Its similiar but is missing some things that i think this repo is doing better; IE naming conventions and config. |
also check out this repo which uses auto update. It works the same as this project, however i was able to greatly simplify it. Thanx! |
as a note, I updated to latest react and electron |
npm start
not 'npm run dev'