Skip to content

update deps, tweaked config, added yarn pkg, and setup distribution w/ docs - 091817 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from

Conversation

p3nGu1nZz
Copy link

@p3nGu1nZz p3nGu1nZz commented Sep 18, 2017

  • updated React dependencies
  • add support to use foreman to run project
  • merged PR to use npm start not 'npm run dev'
  • added .env configuration file
  • suppress browser when starting; only run in electron
  • moved port from package.json to .env
  • add support to use yarn package manager
  • added electron-builder for package distribution
  • updated documentation on how create from ground up

@csepulv
Copy link
Owner

csepulv commented Sep 20, 2017

I appreciate your interest in the project. I'll go through the PR in a few days, but as a few initial notes:

  • updating to latest React, Electron makes complete sense
  • there was already a request for npm start instead of npm run dev. You can take a look at this PR, which was merged into a branch. (also referenced on project README)

It seems you are actively making changes and adding them to the PR. Can you explain your goals a bit?

@p3nGu1nZz
Copy link
Author

p3nGu1nZz commented Sep 20, 2017

I am working getting your fantastic code packaging and distributing with electron-builder.. which is turning into not a small feat. I also have been trying to update and put in more detailed step by step process for this, based on your article.

--i updated the request info to reflect my proposed changes

@csepulv
Copy link
Owner

csepulv commented Sep 20, 2017

I suggest you look at this issue. Another user did this, in their own fork. The details are in the referenced issue.

@p3nGu1nZz p3nGu1nZz changed the title update react to latest 091817 update deps, tweaked config, added yarn pkg, and setup distribution - 091817 Sep 21, 2017
@p3nGu1nZz p3nGu1nZz changed the title update deps, tweaked config, added yarn pkg, and setup distribution - 091817 update deps, tweaked config, added yarn pkg, and setup distribution w/ docs - 091817 Sep 21, 2017
@p3nGu1nZz
Copy link
Author

Thanx for the link i will try to recreate and build using that repo and compare.. i was also able to get a nice build working from this repo . Its similiar but is missing some things that i think this repo is doing better; IE naming conventions and config.

@p3nGu1nZz
Copy link
Author

also check out this repo which uses auto update. It works the same as this project, however i was able to greatly simplify it. Thanx!

@p3nGu1nZz p3nGu1nZz closed this Sep 27, 2017
@csepulv
Copy link
Owner

csepulv commented Nov 22, 2017

as a note, I updated to latest react and electron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants