Skip to content

Added 3 new bundle functions with basic unit tests #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 13, 2023

Conversation

Pawes
Copy link
Contributor

@Pawes Pawes commented Mar 8, 2023

Created the new bundle functions as mentioned by #70
I am new to unit testing in Python so these unit tests are what I could manage by looking at the existing tests.

@andrii-bodnar andrii-bodnar linked an issue Mar 9, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Merging #72 (a1eb56f) into main (1838c8f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   99.33%   99.34%   +0.01%     
==========================================
  Files         132      132              
  Lines        4460     4493      +33     
  Branches       94       95       +1     
==========================================
+ Hits         4430     4463      +33     
  Misses         22       22              
  Partials        8        8              
Impacted Files Coverage Δ
crowdin_api/api_resources/bundles/resource.py 100.00% <100.00%> (ø)
..._resources/bundles/tests/test_bundles_resources.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andrii-bodnar
Copy link
Member

Hi @Pawes, thanks a lot for your contribution!

LGTM, additionally requesting @ayatsyny to review

@andrii-bodnar andrii-bodnar requested a review from ayatsyny March 9, 2023 07:18
@Pawes
Copy link
Contributor Author

Pawes commented Mar 9, 2023

I hope this was what you were thinking @ayatsyny

@andrii-bodnar andrii-bodnar merged commit fa46eee into crowdin:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundles API enhancement
4 participants