fix optimization for bulk updates #224
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mxm
commented
May 17, 2017
mxm
commented
- don't optimize if parameters are not supplied yet
- check the key type before binding parameters
- don't optimize if parameters are not supplied yet - check the key type before binding parameters
|
Thanks for the comments @mfussenegger. I've added an integration test and updated the CHANGES file. |
CHANGES.txt
Outdated
| ================= | ||
|
|
||
| - Fix bulk updates which were broken due to query rewrites. | ||
| - Fix typo to DB API in README |
There was a problem hiding this comment.
There's no need to mention the README fix - only end-user relevant changes should end up in the changes.txt
|
Thanks for jumping in on this @mxm - I was just about to jump in and fix it myself :) Looks like the Travis Tests are failing simply due to the missing newline in Testing now to see if this resolves my issue - appears like it should. |
|
Thanks @jeffnappi. I fixed the missing newline. Let's wait for the tests to pass. |
|
One of my new tests is failing with SQLAlchemy 1.0.16 but passes with 1.1.4. Let's see. |
|
@mfussenegger Is this good to merge? |
seut
pushed a commit
that referenced
this pull request
Jun 20, 2017
- don't optimize if parameters are not supplied yet - check the key type before binding parameters - add test cases for bulk updates This closes #224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.