Skip to content

Commit f1b2238

Browse files
committed
fixup! Adjust connect arguments to enable SSL using SQLAlchemy DB URI
1 parent 3ea46dd commit f1b2238

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

CHANGES.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ Unreleased
1313

1414
- Adjusted connect arguments to accept credentials within the HTTP URI.
1515

16-
- Optionally enable SSL using SQLAlchemy DB URI with parameter ``?ssl=true``.
16+
- Added support for enabling SSL using SQLAlchemy DB URI with parameter
17+
``?ssl=true``.
1718

1819
2020/09/28 0.26.0
1920
=================

src/crate/client/sqlalchemy/dialect.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -197,10 +197,9 @@ def connect(self, host=None, port=None, *args, **kwargs):
197197
server = kwargs.pop('servers')
198198
servers = to_list(server)
199199
if servers:
200-
if "ssl" in kwargs:
201-
use_ssl = asbool(kwargs.pop("ssl"))
202-
if use_ssl:
203-
servers = ["https://" + server for server in servers]
200+
use_ssl = asbool(kwargs.pop("ssl", False))
201+
if use_ssl:
202+
servers = ["https://" + server for server in servers]
204203
return self.dbapi.connect(servers=servers, **kwargs)
205204
return self.dbapi.connect(**kwargs)
206205

0 commit comments

Comments
 (0)