[except.terminate] Better describe the function terminate
#7281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwakely
reviewed
Oct 2, 2024
There was a problem hiding this comment.
I don't think "the C++ runtime" is defined. Maybe just "the program"?
Or "Some errors in a program cannot be recovered from, ..." so that we don't talk about "encountering an error", which sounds like it might just be bad luck rather than well-defined control flow that results from the program logic.
AlisdairM
force-pushed
the
better_describe_terminate
branch
from
94a4ad6 to
425315f
Compare
|
Much better! Thanks! Applied your suggestion, followed by minor grammar tweaks, and force-pushed to allow a clean merge. |
jensmaurer
reviewed
Oct 2, 2024
AlisdairM
force-pushed
the
better_describe_terminate
branch
from
425315f to
8277d9d
Compare
AlisdairM
changed the title
terminate
While 'std:terminate' was originally conceived as the way to report failures in the exception handling machinery, it has evolved to become a more general tool for reporting unrecoverable failures in the C++ runtime. This rewording attempts to address that evolving design, and in doing so addresses the outstanding %FIXME% that the current text is not adequately descriptive in the first place.
AlisdairM
force-pushed
the
better_describe_terminate
branch
from
8277d9d to
53c6318
Compare
|
How do we feel about the proposed description now? |
|
Rebased and force-pushed for good measure. I believe all feedback is addressed, but do we want to flag this for an LWG review as well? |
jwakely
approved these changes
Nov 7, 2024
tkoeppe
reviewed
Nov 7, 2024
jensmaurer
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
std:terminatewas originally conceived as the way to report failures in the exception handling machinery, it has evolved to become a more general tool for reporting unrecoverable failures in the C++ runtime. This rewording attempts to address that evolving design, and in doing so addresses the outstanding %FIXME% that the current text is not adequately descriptive in the first place.