[except.uncaught] Tidy the specification for uncaught exceptions #7276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlisdairM
force-pushed
the
tidy_uncaught_exceptions
branch
2 times, most recently
from
c3ea389 to
3974f00
Compare
|
One last tweak to update the comment in xrefdelta.tex to reference the correct PR number, and to move the first paragraph on uncaught exceptions up one, so that there is a much clearer flow from creating the exception object, being uncaught, then caught, then rethrown, before talking about what happens when an exception is uncaught. I should be done pushing updates to this PR until I get reviews now :) |
Eisenwave
reviewed
Oct 21, 2024
source/exceptions.tex
Outdated
| @@ -317,6 +317,15 @@ | |||
| the selected constructor is odr-used\iref{basic.def.odr} and | |||
| the destructor of \tcode{T} is potentially invoked\iref{class.dtor}. | |||
|
|
|||
| \pnum | |||
| An exception is considered uncaught | |||
There was a problem hiding this comment.
While we're at it, this looks like a definition and presumably should be formatted and indexed as one (exception, uncaught).
There was a problem hiding this comment.
Good point! Added indexing, rebased, and force-pushed.
AlisdairM
force-pushed
the
tidy_uncaught_exceptions
branch
2 times, most recently
from
7514cf9 to
aa18e13
Compare
tkoeppe
reviewed
Nov 19, 2024
source/xrefdelta.tex
Outdated
| % https://github.com/cplusplus/draft/pull/7345 | ||
| \movedxref{basic.stc.inherit}{basic.stc.general} | ||
|
|
||
|
|
AlisdairM
force-pushed
the
tidy_uncaught_exceptions
branch
2 times, most recently
from
766b0f9 to
7b4fc72
Compare
AlisdairM
force-pushed
the
tidy_uncaught_exceptions
branch
from
7b4fc72 to
8d2ba3d
Compare
Several concurrent fixes. First include the normative wording that 'uncaught_exceptions' returns the number of uncaught exceptions *on the current thread*. This wording is present in the core language. Then move the core wording for when an exception is uncaught directly into the text that talks about caught and uncaught exceptions. In the process, turn the reference to into a note, so that there is only one normative specification. Finally, remove [except.uncaught] as it is now empty.
AlisdairM
force-pushed
the
tidy_uncaught_exceptions
branch
from
8d2ba3d to
9b8c25a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several concurrent fixes. First include the normative wording that 'uncaught_exceptions' returns the number of uncaught exceptions on the current thread. This wording is present in the core language.
Then move the core wording for when an exception is uncaught directly into the text that talks about caught and uncaught exceptions. In the process, turn the reference to into a note, so that there is only one normative specification.
Finally, remove [except.uncaught] as it is now empty, and add the missing descriptive sentence to the intro paragraph of [except.special.general]. This happens to produce quite a pleasing page-break, but that is just luck, not design.