[cmp, comparisons] Move description of compare_three_way. #3670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the definition and specification of class compare_three_way from [cmp, 17.11] to [comparisons, 20.14.7]. Also adds a declaration of this class to the synopsis of <functional> and removes a paragraph that says (now redundantly) that the class is available also via inclusion of <functional>. This is a partial response to NB GB 175 (C++20 CD).
|
@jensmaurer: Would you like to review this PR? |
jensmaurer
approved these changes
Feb 13, 2020
|
Thanks! Do you think we can merge this now? I don't see any upcoming core issues for this section? |
|
@jensmaurer, @zygoloid, @mclow, @jwakely: in LWG review it emerged that the pattern of "In addition to ... available when the header |
|
Feel free to assign an issue to me, asking to unify how we say that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the definition and specification of class compare_three_way from
[cmp, 17.11] to [comparisons, 20.14.7].
This is a partial response to NB GB 175 (C++20 CD).
Fixes cplusplus/nbballot#173.