Skip to content

Commit f8004bb

Browse files
committed
incorporate review comments
1 parent eff9d44 commit f8004bb

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

Directory.Build.props

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,16 +54,18 @@
5454
<SystemReflectionMetadataVersion>1.6.0</SystemReflectionMetadataVersion>
5555
<SystemCollectionsImmutableVersion>1.5.0</SystemCollectionsImmutableVersion>
5656

57-
<!-- msBuild task with dependencies https://natemcmaster.com/blog/2017/11/11/msbuild-task-with-dependencies/
58-
Aligning versions with MSBuild
59-
If you need a dependency that is also used in MSBuild itself, you have to align with the version MSBuild uses.
60-
This includes System.Reflection.Metadata, System.Collections.Immutable, NuGet, Newtonsoft.Json, and others.
61-
See example: dependencies.props (https://github.com/aspnet/BuildTools/blob/1f3f14382764e06b7e691e5ee89d12a280249284/build/dependencies.props#L19-L29)
57+
<!-- some additional information about dependency management limitations for MSBuild tasks (coverlet.msbuild.tasks)
58+
- msBuild task with dependencies https://natemcmaster.com/blog/2017/11/11/msbuild-task-with-dependencies/
59+
- Aligning versions with MSBuild
60+
- If you need a dependency that is also used in MSBuild itself, you have to align with the version MSBuild uses.
61+
- This includes System.Reflection.Metadata, System.Collections.Immutable, NuGet, Newtonsoft.Json, and others.
62+
- See example: dependencies.props (https://github.com/aspnet/BuildTools/blob/1f3f14382764e06b7e691e5ee89d12a280249284/build/dependencies.props#L19-L29)"
6263
63-
.NET 8.0.3xx core-sdk-tasks https://github.com/dotnet/installer/blob/release/8.0.3xx/src/core-sdk-tasks/core-sdk-tasks.csproj
64+
.NET 8.0.3xx (MSBuild) core-sdk-tasks version details https://github.com/dotnet/installer/blob/release/8.0.3xx/src/core-sdk-tasks/core-sdk-tasks.csproj
6465
65-
align package versions coverlet.core with coverlet.collector (vstest) and coverlet.msbuild.tasks (.NET SDK MSBuild)
66+
ALIGN PACKAGE VERSIONS of coverlet.core with coverlet.collector (vstest) and coverlet.msbuild.tasks (.NET SDK MSBuild)
6667
68+
e.g. candidates for version conflicts:
6769
<MicrosoftBuildTaskVersion>15.7.179</MicrosoftBuildTaskVersion>
6870
<MicrosoftBuildTaskUtilitiesCoreVersion>15.7.179</MicrosoftBuildTaskUtilitiesCoreVersion>
6971
<NuGetBuildTasksPackageVersion>6.9.0-rc.86</NuGetBuildTasksPackageVersion>

src/coverlet.core/CoverageResult.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ internal class Branches : List<BranchInfo> { }
2424
internal class Method
2525
{
2626
[JsonConstructor]
27-
public Method()
27+
internal Method()
2828
{
2929
Lines = [];
3030
Branches = [];

0 commit comments

Comments
 (0)