Skip to content

mempool: don't log error when trying to remove a tx that's not present #651

@Pitasi

Description

@Pitasi

Using the new mempool, during the genesis startup of a chain, you will see an error being logged for each gentx you have:

3:14PM ERR failed to remove Cosmos transaction error="tx not found in mempool" module=ExperimentalEVMMempool
Image

as these special transactions were clearly never be added to the mempool.

I think it is safe to ignore errors when a transaction was tried to be removed from the mempool but it wasn't found at all. Cosmos SDK is doing the same here:

https://github.com/cosmos/cosmos-sdk/blob/648633cc6d1eac408c87ad892f237cebd1ecc549/baseapp/baseapp.go#L881-L885

When you start having more and more gentxs, it can be a bit alarming to see a wall of errors 😁

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions