Skip to content

Bad Maxtx-gas-want implementation that may lead to proposal rejection of normal nodes. #593

@Hellobloc

Description

@Hellobloc

func UpdateCumulativeGasWanted(

introduce

In the following code, maxtxgaswant is used to limit the upper limit of messages. However, in the actual implementation, it did not realize its function. On the contrary, due to the difference of the cumulative results of gaswant during checktx and processhandler, it may cause the normal node to send a proposal that was rejected by processhandler because it contained sub-message transactions beyond maxtxgaswant.

Risk scenario

Specifically, for those nodes whose maxtxgaswant is not 0, malicious users can send a message that the tx contains a msg which gas greater than maxtxgaswant, so that the gas accumulation of the transaction in the checktx phase is smaller and enters the transaction pool. And during the processhandler, the proposal may be rejected because of the normal calculation of gas and the higher gaswant than before.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions