Skip to content

Support vertical sharding for parquet queryable #6879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jul 14, 2025

What this PR does:

This PR implements vertical sharding for parquet queryable by leveraging a series label filtering hook in parquet-common. See prometheus-community/parquet-common#83. Since that PR is still not merged so mark this PR as draft.

Integration test for parquet querier has been updated to enable vertical sharding.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@yeya24 yeya24 force-pushed the parquet-vertical-sharding branch from 1c79456 to 0c64f1b Compare July 14, 2025 04:59
@yeya24 yeya24 marked this pull request as ready for review July 15, 2025 17:44
@dosubot dosubot bot added component/querier go Pull requests that update Go code labels Jul 15, 2025
Copy link
Member

@alanprot alanprot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! thanks

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 15, 2025
@yeya24
Copy link
Contributor Author

yeya24 commented Jul 16, 2025

The fuzz failure seems related. I will spend more time investigating it

Signed-off-by: yeya24 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/querier go Pull requests that update Go code lgtm This PR has been approved by a maintainer size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants