-
Notifications
You must be signed in to change notification settings - Fork 823
add parquet labels cache #6835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add parquet labels cache #6835
Conversation
Flaky test worth taking a closer look |
if parquetLabelsCache != nil { | ||
cachingConfigured = true | ||
parquetLabelsCache = cache.NewTracingCache(parquetLabelsCache) | ||
cfg.CacheGetRange("parquet-labels", parquetLabelsCache, matchers.GetParquetLabelsMatcher(), parquetLabelsConfig.SubrangeSize, parquetLabelsConfig.AttributesTTL, parquetLabelsConfig.SubrangeTTL, parquetLabelsConfig.MaxGetRangeRequests) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For both, this and the chunks cache, should we cache also the attributes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can see that AttributesTTL
already a config. It is part of the GetRange cache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice! missed that! thanks
Signed-off-by: yeya24 <[email protected]>
Signed-off-by: yeya24 <[email protected]>
4365ff8
to
870ed1e
Compare
What this PR does:
Add Parquet Labels file cache using the caching bucket. This allows caching Parquet Labels File GetRange requests to reduce API calls to the object storage.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]