Add alertmanager config to single process documents #6274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Edit-single-process-documents
branch
from
265e97f to
ea4cff6
Compare
3 tasks
|
Thanks! |
alanprot
approved these changes
Oct 17, 2024
yeya24
reviewed
Oct 17, 2024
| alertmanager_storage: | ||
| backend: local | ||
| local: | ||
| # Make sure file exist |
There was a problem hiding this comment.
I am wondering if we can improve this a bit. Do we require the folder for rules to exist? Or Ruler will try to create it beforehand
There was a problem hiding this comment.
Ruler checks the rule file as well, but it doesn't abort. However, the alertmanager abort. So, I added the annotations only to the alertmanager.
The alertmanager logs are as follows:
ts=2024-10-18T01:05:01.787107Z caller=cortex.go:450 level=error msg="module failed" module=alertmanager err="invalid service state: Failed, expected: Running, failure: failed to list users with alertmanager configuration: unable to walk file path at /tmp/cortex/alerts: lstat /tmp/cortex/alerts: no such file or directory"
level=error msg="error running cortex" err="failed services\ngithub.com/cortexproject/cortex/pkg/cortex.(*Cortex)
The ruler logs:
ts=2024-10-18T01:07:18.186139Z caller=ruler.go:727 level=error msg="unable to list rules" err="unable to read dir /tmp/cortex/rules: open /tmp/cortex/rules: no such file or directory"
But, it doesn't abort.
yeya24
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6204 added Alertmanager to
alltarget.However, single process documents do not contain alertmanager configs, so the Cortex fails to start using these configs.
This PR adds alertmanager configs to single process documents.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]