Skip to content

cleanup docs for query_store_for_labels_enabled config #6156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Aug 13, 2024

What this PR does:

Follow up of #5984. The config was removed but the flags still exist in docs.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Member

@CharlieTLe CharlieTLe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should note that starting v1.17.2 that this will be the new behavior?

@yeya24
Copy link
Contributor Author

yeya24 commented Aug 13, 2024

@CharlieTLe Yeah I think we can document that clearly. But a better way is to have versioned doc in Cortex. We cannot document this for every feature we have.

@yeya24 yeya24 force-pushed the doc-update-querier-flags branch from ddfba52 to 5aaa4bf Compare August 13, 2024 22:42
@yeya24
Copy link
Contributor Author

yeya24 commented Aug 13, 2024

@CharlieTLe I updated the doc to mention the release version

@yeya24 yeya24 merged commit 76ca69d into cortexproject:master Aug 14, 2024
16 checks passed
@yeya24 yeya24 deleted the doc-update-querier-flags branch August 14, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants