Skip to content

Enable 'snappy-block' compression on ingester clients by default #6148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 9, 2024
Merged

Enable 'snappy-block' compression on ingester clients by default #6148

merged 5 commits into from
Aug 9, 2024

Conversation

alanprot
Copy link
Member

@alanprot alanprot commented Aug 9, 2024

What this PR does:
Enable snappy-block compression on ingester clients.

This compression gives up to 10x less network and no notable CPU difference:

See:
#5215 (comment)
#5215 (comment)

This compression showed to reduce the network
Which issue(s) this PR fixes:
Fixes #

Checklist

  • [NA] Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@alanprot
changelog
98c2c58 
Signed-off-by: alanprot <[email protected]>
@alanprot alanprot marked this pull request as ready for review August 9, 2024 18:32
@alanprot alanprot requested review from yeya24 and friedrichg August 9, 2024 18:32
@alanprot
lint
42fb004 
Signed-off-by: alanprot <[email protected]>
yeya24
yeya24 approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. Thanks!

@yeya24
Copy link
Contributor

yeya24 commented Aug 9, 2024 

18:51:49 distributor: ts=2024-08-09T18:51:49.177830607Z caller=logging.go:119 level=warn traceID=0d5452a26b3d6a15 msg="POST /api/prom/push (500) 2.609397ms Response: \"maxFailure (quorum) on a given error family, addr=192.168.96.5:9095 state=ACTIVE zone=, rpc error: code = Unimplemented desc = grpc: Decompressor is not installed for grpc-encoding \\\"snappy-block\\\"\\n\" ws: false; Accept-Encoding: gzip; Content-Encoding: snappy; Content-Length: 44; Content-Type: application/x-protobuf; User-Agent: Go-http-client/1.1; X-Prometheus-Remote-Write-Version: 0.1.0; X-Scope-Orgid: user-1; "

backward compatibility test failed.

@alanprot alanprot force-pushed the snappy-for-ingester-client branch from 197406a to 795ecc8 Compare August 9, 2024 21:10
@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 9, 2024
@alanprot alanprot force-pushed the snappy-for-ingester-client branch from b2cf98c to d20db94 Compare August 9, 2024 21:37
@alanprot alanprot force-pushed the snappy-for-ingester-client branch from e593af7 to cd31da8 Compare August 9, 2024 22:33
@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 9, 2024
@alanprot alanprot merged commit f88eddb into cortexproject:master Aug 9, 2024
16 checks passed
friedrichg
friedrichg reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 That is what I use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedrichg friedrichg friedrichg left review comments

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanprot @yeya24 @friedrichg