Validating new fields on the PagerDuty AM config #5290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AM config Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
alvinlin123
approved these changes
Apr 26, 2023
alanprot
added a commit
to alanprot/cortex
that referenced
this pull request
Apr 26, 2023
* Not Allowing to set the new service_key_file and routing_key_file on AM config Signed-off-by: Alan Protasio <[email protected]> * changelog Signed-off-by: Alan Protasio <[email protected]> * fix multiples types Signed-off-by: Alan Protasio <[email protected]> --------- Signed-off-by: Alan Protasio <[email protected]>
alanprot
added a commit
that referenced
this pull request
Apr 27, 2023
* Handle grpc code resource exhausted for store gateway (#5286) * handle grpc code resource exhausted for store gateway Signed-off-by: Ben Ye <[email protected]> * fix lint Signed-off-by: Ben Ye <[email protected]> * update changelog Signed-off-by: Ben Ye <[email protected]> * try fixing test Signed-off-by: Ben Ye <[email protected]> * try to fix E2E test Signed-off-by: Ben Ye <[email protected]> * lint Signed-off-by: Ben Ye <[email protected]> * try again Signed-off-by: Ben Ye <[email protected]> * fix message Signed-off-by: Ben Ye <[email protected]> * remove labels API Signed-off-by: Ben Ye <[email protected]> * remove logic to check string contains Signed-off-by: Ben Ye <[email protected]> * make limiter vars private Signed-off-by: Ben Ye <[email protected]> --------- Signed-off-by: Ben Ye <[email protected]> * Validating new fields on the PagerDuty AM config (#5290) * Not Allowing to set the new service_key_file and routing_key_file on AM config Signed-off-by: Alan Protasio <[email protected]> * changelog Signed-off-by: Alan Protasio <[email protected]> * fix multiples types Signed-off-by: Alan Protasio <[email protected]> --------- Signed-off-by: Alan Protasio <[email protected]> --------- Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Alan Protasio <[email protected]> Co-authored-by: Ben Ye <[email protected]>
yeya24
added a commit
to yeya24/cortex
that referenced
this pull request
Apr 28, 2023
* Handle grpc code resource exhausted for store gateway (cortexproject#5286) * handle grpc code resource exhausted for store gateway Signed-off-by: Ben Ye <[email protected]> * fix lint Signed-off-by: Ben Ye <[email protected]> * update changelog Signed-off-by: Ben Ye <[email protected]> * try fixing test Signed-off-by: Ben Ye <[email protected]> * try to fix E2E test Signed-off-by: Ben Ye <[email protected]> * lint Signed-off-by: Ben Ye <[email protected]> * try again Signed-off-by: Ben Ye <[email protected]> * fix message Signed-off-by: Ben Ye <[email protected]> * remove labels API Signed-off-by: Ben Ye <[email protected]> * remove logic to check string contains Signed-off-by: Ben Ye <[email protected]> * make limiter vars private Signed-off-by: Ben Ye <[email protected]> --------- Signed-off-by: Ben Ye <[email protected]> * Validating new fields on the PagerDuty AM config (cortexproject#5290) * Not Allowing to set the new service_key_file and routing_key_file on AM config Signed-off-by: Alan Protasio <[email protected]> * changelog Signed-off-by: Alan Protasio <[email protected]> * fix multiples types Signed-off-by: Alan Protasio <[email protected]> --------- Signed-off-by: Alan Protasio <[email protected]> --------- Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Alan Protasio <[email protected]> Co-authored-by: Ben Ye <[email protected]> Signed-off-by: Ben Ye <[email protected]>
yeya24
pushed a commit
to yeya24/cortex
that referenced
this pull request
Apr 28, 2023
* Not Allowing to set the new service_key_file and routing_key_file on AM config Signed-off-by: Alan Protasio <[email protected]> * changelog Signed-off-by: Alan Protasio <[email protected]> * fix multiples types Signed-off-by: Alan Protasio <[email protected]> --------- Signed-off-by: Alan Protasio <[email protected]> Signed-off-by: Ben Ye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Validate the PagerDuty config to block setting
routing_key_fileandservice_key_file.This fields got introduced on: prometheus/alertmanager@1045dc0
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]