func (i *Ingester) Push has some performance issues.(#4915) #4940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
reviewed
Oct 31, 2022
pkg/ingester/active_series_test.go
Outdated
|
|
||
| "github.com/prometheus/prometheus/model/labels" | ||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func copyFn(l labels.Labels) labels.Labels { return l } | ||
|
|
||
| func FromLabelAdaptersToLabels(ls []labels.Label) labels.Labels { | ||
| return *(*labels.Labels)(unsafe.Pointer(&ls)) | ||
| } |
There was a problem hiding this comment.
This seems redundant. Let's use cortexpb.FromLabelAdaptersToLabels.
There was a problem hiding this comment.
cortexpb.FromLabelAdaptersToLabels only handle a []LabelAdapter labels, this may change current tests' variables, so a new local FromLabelAdaptersToLabels seems better suitable.
pkg/ingester/active_series.go
Outdated
| @@ -53,8 +53,8 @@ func NewActiveSeries() *ActiveSeries { | |||
| } | |||
|
|
|||
| // Updates series timestamp to 'now'. Function is called to make a copy of labels if entry doesn't exist yet. | |||
| func (c *ActiveSeries) UpdateSeries(series labels.Labels, now time.Time, labelsCopy func(labels.Labels) labels.Labels) { | |||
| fp := fingerprint(series) | |||
There was a problem hiding this comment.
If we are not going to use fingerprint(series), then it is not used anywhere else. Let's remove related code
There was a problem hiding this comment.
yes, has been removed.
pkg/ingester/ingester.go
Outdated
| ref, copiedLabels := app.GetRef(cortexpb.FromLabelAdaptersToLabels(ts.Labels)) | ||
| tsLabels := cortexpb.FromLabelAdaptersToLabels(ts.Labels) | ||
| tsLabelsHash := tsLabels.Hash() | ||
| ref, copiedLabels := app.GetRef(tsLabels,tsLabelsHash) |
There was a problem hiding this comment.
because this is related with vendor/prometheus . don't know how to match these two projects' codes.
BTW, the PR of prometheus is pendding.
prometheus/prometheus#11485
t00350320
added a commit
to t00350320/cortex
that referenced
this pull request
Nov 1, 2022
Signed-off-by: tanghengjian <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tanghengjian [email protected]
issue details in #4915