Use the new GO 1.19 build image #4829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alvin Lin <[email protected]>
alvinlin123
force-pushed
the
try-go-1.19-build-image
branch
from
c1097e7 to
a65ae9a
Compare
alanprot
approved these changes
Aug 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Build Cortex with Go 1.19.
I had to fix some lint errors because I had to switch from
golinttorevivebecausegolintis not maintained anymore and is deprecated. After the switch I tried to fix as much linting error as I can; however, I can't fix all the error of using deprecatedio/ioutilsmodule because there are way too many; I will follow this up with #4828. For now I configure linter to ignore deprecated module usage error.Which issue(s) this PR fixes:
Fixes #4817
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]