Add rand to sparse requests for rejoin memberlist cluster #4747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielblando
changed the title
danielblando
force-pushed
the
jitterRejoinInterval
branch
from
a6f5d6b to
0caef42
Compare
danielblando
force-pushed
the
jitterRejoinInterval
branch
from
0caef42 to
5c5aebb
Compare
|
LGTM |
alanprot
approved these changes
Jun 9, 2022
alvinlin123
reviewed
Jun 9, 2022
danielblando
force-pushed
the
jitterRejoinInterval
branch
from
5c5aebb to
9ebf137
Compare
Signed-off-by: Daniel Blando <[email protected]>
danielblando
force-pushed
the
jitterRejoinInterval
branch
from
9ebf137 to
071dd5f
Compare
alvinlin123
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Blando [email protected]
What this PR does:
When scaling pods simultaneously, we have a chance of then rejoining together. This can cause CPU instability with spikes around the time pods are rejoining. The PR try to mitigate the issue distributing the requests adding a jitter to reset the initial time for each pod.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]