Fix incorrectly named cache metrics #4686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harry671003
force-pushed
the
fix_cache_metrics
branch
from
1f16c53 to
3215766
Compare
pracucci
approved these changes
Mar 28, 2022
CHANGELOG.md
Outdated
| @@ -3,6 +3,7 @@ | |||
| ## master / unreleased | |||
|
|
|||
| * [FEATURE] Ruler: Add `external_labels` option to tag all alerts with a given set of labels. | |||
| * [BUGFIX] Fix incorrectly named `cortex_cache_fetched_keys` and `cortex_cache_hits` metrics. #4686 | |||
There was a problem hiding this comment.
I suggest to both mention the old and new name, to help users better understand the change.
harry671003
force-pushed
the
fix_cache_metrics
branch
from
3215766 to
1a5b203
Compare
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
harry671003
force-pushed
the
fix_cache_metrics
branch
from
1a5b203 to
c87ab0a
Compare
alanprot
approved these changes
Apr 1, 2022
|
LGTM |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 🌲 Harry 🌊 John 🏔 [email protected]
What this PR does:
The following query-frontend cache metrics are incorrectly named.
These counter metrics are not ending in
totalas per the convention.Which issue(s) this PR fixes:
Fixes #4685
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]