Check ingester has tokens before reporting ready #1260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be visible if you curl the `/ready` endpoint. This is to remove some head-scratching when debugging. Signed-off-by: Bryan Boreham <[email protected]>
This shouldn't happen in normal operation, and reporting un-ready will halt a Kubernetes rolling update which what we want if something has gone wrong. Signed-off-by: Bryan Boreham <[email protected]>
tomwilkie
reviewed
Mar 6, 2019
pkg/ring/lifecycler.go
Outdated
| } | ||
|
|
||
| // Ingester always take at least minReadyDuration to become ready to work | ||
| // around race conditions with ingesters exiting and updating the ring | ||
| if time.Now().Sub(i.startTime) < i.cfg.MinReadyDuration { | ||
| return false | ||
| return fmt.Errorf("Not ready: waiting for %v after startup", i.cfg.MinReadyDuration) |
There was a problem hiding this comment.
Generally considered that errors should be lowercase (https://github.com/golang/go/wiki/Errors). The argument is that they'll be prefixed by the caller, so you might want to put the "Not ready: %v" bit in the HTTP handler?
Signed-off-by: Bryan Boreham <[email protected]>
khaines
approved these changes
Mar 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1112
Also state the reason why an ingester is not reporting ready - the reason will be visible if you curl the
/readyendpoint. This is to remove some head-scratching when debugging.