Update according to Goutham's comments

Signed-off-by: Giedrius Statkevičius <[email protected]>

Author: GiedriusS

CHANGELOG.md

@@ -2,8 +2,8 @@
 
 ## master / unreleased
 
+* [CHANGE] The frontend component now does not cache results if it finds a `Cache-Control` header and if one of its values is `no-store`
 * [ENHANCEMENT] metric `cortex_ingester_flush_reasons` gets a new `reason` value: `Spread`, when `-ingester.spread-flushes` option is enabled.
-
 * [CHANGE] Flags changed with transition to upstream Prometheus rules manager:
   * `ruler.client-timeout` is now `ruler.configs.client-timeout` in order to match `ruler.configs.url`
   * `ruler.group-timeout`has been removed

pkg/querier/queryrange/results_cache.go

@@ -142,7 +142,7 @@ func (s resultsCache) Do(ctx context.Context, r Request) (Response, error) {
 // shouldCacheResponse says whether the response should be cached or not.
 func shouldCacheResponse(r Response) bool {
 	if promResp, ok := r.(*PrometheusResponse); ok {
-		shouldNotCache := false
+		shouldCache := true
 	outer:
 		for _, hv := range promResp.Headers {
 			if hv == nil {
@@ -153,12 +153,12 @@ func shouldCacheResponse(r Response) bool {
 			}
 			for _, v := range hv.Values {
 				if v == noCacheValue {
-					shouldNotCache = true
+					shouldCache = false
 					break outer
 				}
 			}
 		}
-		return !shouldNotCache
+		return shouldCache
 	}
 	return true
 }