Add read lock + increment right before sending series request

Signed-off-by: Justin Jung <[email protected]>

Author: justinjung04

pkg/storegateway/bucket_stores.go

@@ -301,13 +301,8 @@ func (u *BucketStores) Series(req *storepb.SeriesRequest, srv storepb.Store_Seri
 	defer spanLog.Span.Finish()
 
 	maxInflightRequests := u.cfg.BucketStore.MaxInflightRequests
-	if maxInflightRequests > 0 {
-		if u.inflightRequestCnt >= maxInflightRequests {
-			return ErrTooManyInflightRequests
-		}
-
-		u.incrementInflightRequestCnt()
-		defer u.decrementInflightRequestCnt()
+	if maxInflightRequests > 0 && u.getInflightRequestCnt() >= maxInflightRequests {
+		return ErrTooManyInflightRequests
 	}
 
 	userID := getUserIDFromGRPCContext(spanCtx)
@@ -330,6 +325,11 @@ func (u *BucketStores) Series(req *storepb.SeriesRequest, srv storepb.Store_Seri
 		return nil
 	}
 
+	if maxInflightRequests > 0 {
+		u.incrementInflightRequestCnt()
+		defer u.decrementInflightRequestCnt()
+	}
+
 	err = store.Series(req, spanSeriesServer{
 		Store_SeriesServer: srv,
 		ctx:                spanCtx,
@@ -338,6 +338,12 @@ func (u *BucketStores) Series(req *storepb.SeriesRequest, srv storepb.Store_Seri
 	return err
 }
 
+func (u *BucketStores) getInflightRequestCnt() int {
+	u.inflightRequestMu.RLock()
+	defer u.inflightRequestMu.RUnlock()
+	return u.inflightRequestCnt
+}
+
 func (u *BucketStores) incrementInflightRequestCnt() {
 	u.inflightRequestMu.Lock()
 	u.inflightRequestCnt++