fix(CSidebar): onShowChange callback behavior overwritten for overlaid

xidedix · xidedix · commit c463ea566e3b · 2020-10-15T19:31:46.000+02:00
diff --git a/src/template/CSidebar.js b/src/template/CSidebar.js
@@ -95,8 +95,11 @@ const CSidebar = props => {
   }
 
   const closeSidebar = () => {
-    onShowChange && onShowChange(overlaid ? false : 'responsive')
-    setIsOpen(overlaid ? false : 'responsive')
+    if (typeof onShowChange === 'function') {
+      onShowChange(overlaid ? false : 'responsive')
+    } else {
+      setIsOpen(overlaid ? false : 'responsive')
+    }
   }
 
   const isOnMobile = () => {

Original file line number	Diff line number	Diff line change
`@@ -95,8 +95,11 @@ const CSidebar = props => {`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`const closeSidebar = () => {`
`98`		`- onShowChange && onShowChange(overlaid ? false : 'responsive')`
`99`		`- setIsOpen(overlaid ? false : 'responsive')`
	`98`	`+ if (typeof onShowChange === 'function') {`
	`99`	`+ onShowChange(overlaid ? false : 'responsive')`
	`100`	`+ } else {`
	`101`	`+ setIsOpen(overlaid ? false : 'responsive')`
	`102`	`+ }`
`100`	`103`	`}`
`101`	`104`
`102`	`105`	`const isOnMobile = () => {`