Skip to content
This repository was archived by the owner on Mar 18, 2019. It is now read-only.

Javascript files in lib not transpiled #49

Open
roelio opened this issue Apr 1, 2018 · 2 comments
Open

Javascript files in lib not transpiled #49

roelio opened this issue Apr 1, 2018 · 2 comments

Comments

@roelio
Copy link

roelio commented Apr 1, 2018

Hi Tom,

First of all thanks for this library! Together with DRF it seems to be a good combo to separate or front- and backend.

We had some problems including this dependency in our frontend build process (we also use browserify and babelify). The lib files are not transpiled and gave us some issues when using the library in browsers that dont support es6 stuff. Check also https://github.com/babel/babelify#why-arent-files-in-node_modules-being-transformed

A solution would be do rearrange the package a little bit like suggested in this SO answer https://stackoverflow.com/a/29738448.

Thanks for all your hard work!

Cheers,
Roel

@josmo josmo mentioned this issue May 29, 2018
@firflant
Copy link

It sounds to be an important thing as it blocks the usage of core-api on some projects. Voting up for the @josmo 's PR

@tomchristie
Copy link
Contributor

Noted, thanks!

I'm not pushing any new releases to core-api at the moment, as all the API documentation and client tooling is gradually being consolidated into the API Star project. (Instead of mixed in throughout REST framework, core-api, core-schema, itypes) I'll take this into consideration once we get around to the next JS release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants