Skip to content

MINOR: Fix compilation error from createKeyStore #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2020
Merged

MINOR: Fix compilation error from createKeyStore #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/test/java/io/confluent/rest/ApiHeadersTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ private static void createKeystoreWithCert(File file, String alias, Map<String,
final X509Certificate cert = new CertificateBuilder(30, "SHA1withRSA")
.sanDnsNames("localhost").generate("CN=mymachine.local, O=A client", keypair);

TestSslUtils.createKeyStore(file.getPath(), new Password(SSL_PASSWORD), alias,
TestSslUtils.createKeyStore(file.getPath(), new Password(SSL_PASSWORD), new Password(SSL_PASSWORD), alias,
keypair.getPrivate(), cert);
certs.put(alias, cert);
}
Expand Down
4 changes: 2 additions & 2 deletions core/src/test/java/io/confluent/rest/SslTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ private void createKeystoreWithCert(File file, String alias, Map<String, X509Cer
CertificateBuilder certificateBuilder = new CertificateBuilder(30, "SHA1withRSA");
X509Certificate cCert = certificateBuilder.sanDnsNames("localhost")
.generate("CN=mymachine.local, O=A client", keypair);
TestSslUtils.createKeyStore(file.getPath(), new Password(SSL_PASSWORD), alias, keypair.getPrivate(), cCert);
TestSslUtils.createKeyStore(file.getPath(), new Password(SSL_PASSWORD), new Password(SSL_PASSWORD),alias, keypair.getPrivate(), cCert);
certs.put(alias, cCert);
}

Expand All @@ -125,7 +125,7 @@ private void createWrongKeystoreWithCert(File file, String alias, Map<String, X5
CertificateBuilder certificateBuilder = new CertificateBuilder(30, "SHA1withRSA");
X509Certificate cCert = certificateBuilder.sanDnsNames("fail")
.generate("CN=mymachine.local, O=A client", keypair);
TestSslUtils.createKeyStore(file.getPath(), new Password(SSL_PASSWORD), alias, keypair.getPrivate(), cCert);
TestSslUtils.createKeyStore(file.getPath(), new Password(SSL_PASSWORD), new Password(SSL_PASSWORD), alias, keypair.getPrivate(), cCert);
certs.put(alias, cCert);
}

Expand Down