Skip to content

Commit da1d8d4

Browse files
authored
Disable flaky tests (#481)
There are 2 kinds of flake are disabled in this PR: - Pure flaky (pass locally but failed occasionally in CI), in `RequestLogHandlerIntegrationTest#test_CustomRequestLog_registeredToCorrectListener` and `MetricsResourceMethodApplicationListenerIntegrationTest#testMetricLatencySloSlaEnabled` - CI builder/upstream behaviour change (also pass locally and there isn't easy way to reproduce locally), in `Http2FipsTest`, CI was running all fine until this [build](https://semaphore.ci.confluent.io/workflows/6430372a-191f-4058-ae34-fb5d6786076c?pipeline_id=60c5681c-7fb5-429c-9dd7-444de133f38b), when all of a sudden, it starts to fail consistently. There is no change to rest-utils, so the suspect could be CI env change or upstream change. Created a JIRA (in Disabled tag) to resolve those flaky tests.
1 parent 19b3c36 commit da1d8d4

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

core/src/test/java/io/confluent/rest/RequestLogHandlerIntegrationTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
import org.eclipse.jetty.server.Slf4jRequestLogWriter;
4242
import org.junit.jupiter.api.AfterEach;
4343
import org.junit.jupiter.api.BeforeEach;
44+
import org.junit.jupiter.api.Disabled;
4445
import org.junit.jupiter.api.Tag;
4546
import org.junit.jupiter.api.Test;
4647
import org.mockito.ArgumentCaptor;
@@ -70,6 +71,7 @@ public void tearDown() throws Exception {
7071
}
7172

7273
@Test
74+
@Disabled("KNET-15387: this test is flaky and needs to be fixed")
7375
public void test_CustomRequestLog_registeredToCorrectListener() throws Exception {
7476
Map<String, Object> props = new HashMap<>();
7577
props.put(RestConfig.LISTENERS_CONFIG,

core/src/test/java/io/confluent/rest/metrics/MetricsResourceMethodApplicationListenerIntegrationTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import org.glassfish.jersey.server.ServerProperties;
2323
import org.junit.jupiter.api.AfterEach;
2424
import org.junit.jupiter.api.BeforeEach;
25+
import org.junit.jupiter.api.Disabled;
2526
import org.junit.jupiter.api.DisplayName;
2627
import org.junit.jupiter.api.Tag;
2728
import org.junit.jupiter.api.Test;
@@ -535,6 +536,7 @@ public void testMetricReporterConfiguration() {
535536
}
536537

537538
@Test
539+
@Disabled("KNET-15387: this test is flaky and needs to be fixed")
538540
public void testMetricLatencySloSlaEnabled() {
539541
makeSuccessfulCall();
540542

fips-tests/src/test/java/io/confluent/rest/Http2FipsTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,15 @@
5555
import org.junit.jupiter.api.AfterAll;
5656
import org.junit.jupiter.api.BeforeAll;
5757
import org.junit.jupiter.api.BeforeEach;
58+
import org.junit.jupiter.api.Disabled;
5859
import org.junit.jupiter.api.Test;
5960
import org.slf4j.Logger;
6061
import org.slf4j.LoggerFactory;
6162

6263
/**
6364
* This tests HTTP/2 support in the REST server with FIPS mode enabled.
6465
**/
66+
@Disabled("KNET-15387: this test is flaky and needs to be fixed")
6567
class Http2FipsTest {
6668
private static final String BC_FIPS_APPROVED_ONLY_PROP = "org.bouncycastle.fips.approved_only";
6769
private static final Logger log = LoggerFactory.getLogger(Http2FipsTest.class);

0 commit comments

Comments
 (0)