Skip to content

Commit a04ed80

Browse files
Merge branch '7.7.x' into master by trnguyencflt
2 parents da1d8d4 + 46ec76e commit a04ed80

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

core/src/main/java/io/confluent/rest/ApplicationServer.java

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
import java.util.StringTokenizer;
3131
import java.util.concurrent.BlockingQueue;
3232
import org.apache.kafka.common.MetricName;
33-
import org.apache.kafka.common.config.ConfigException;
3433
import org.apache.kafka.common.metrics.Gauge;
3534
import org.apache.kafka.common.metrics.Metrics;
3635
import org.eclipse.jetty.alpn.server.ALPNServerConnectionFactory;
@@ -132,35 +131,31 @@ public List<Application<?>> getApplications() {
132131

133132
private void attachMetricsListener(String listenerName, Metrics metrics,
134133
Map<String, String> tags) {
135-
boolean hasNetworkConnector = false;
136134
for (NetworkTrafficServerConnector connector : connectors) {
137135
if (Objects.equals(connector.getName(), listenerName)) {
138136
MetricsListener metricsListener = new MetricsListener(metrics, "jetty", tags);
139137
connector.addNetworkTrafficListener(metricsListener);
140138
log.info("Registered {} to connector of listener: {}",
141139
metricsListener.getClass().getSimpleName(), listenerName);
142-
hasNetworkConnector = true;
143140
}
144141
}
145-
if (!hasNetworkConnector) {
146-
throw new ConfigException("No network connector found for listener: " + listenerName);
142+
if (connectors.isEmpty()) {
143+
log.warn("No network connector configured for listener: {}", listenerName);
147144
}
148145
}
149146

150147
private void attachNetworkTrafficRateLimitListener(RestConfig appConfig, String listenerName) {
151148
if (appConfig.getNetworkTrafficRateLimitEnable()) {
152-
boolean hasNetworkConnector = false;
153149
for (NetworkTrafficServerConnector connector : connectors) {
154150
if (Objects.equals(connector.getName(), listenerName)) {
155151
NetworkTrafficListener rateLimitListener = new RateLimitNetworkTrafficListener(appConfig);
156152
connector.addNetworkTrafficListener(rateLimitListener);
157153
log.info("Registered {} to connector of listener: {}",
158154
rateLimitListener.getClass().getSimpleName(), listenerName);
159-
hasNetworkConnector = true;
160155
}
161156
}
162-
if (!hasNetworkConnector) {
163-
throw new ConfigException("No network connector found for listener: " + listenerName);
157+
if (connectors.isEmpty()) {
158+
log.warn("No network connector configured for listener: {}", listenerName);
164159
}
165160
}
166161
}

0 commit comments

Comments
 (0)