chore(deps): update commons-cli version #556

mjsax · 2025-05-26T22:23:58Z

Splitting out one version bump from #541 to apply required code changes.

Copilot

Pull Request Overview

This PR updates the commons-cli dependency from version 1.4 to 1.9.0 and makes the accompanying code changes required by the new dependency version.

Updated dependency version in pom.xml
Modified the calls to cl.getOptionValue() in multiple modules by explicitly casting the default null value to (String) null

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 14 comments.

Show a summary per file

File	Description
src/main/java/io/confluent/examples/streams/microservices/util/ProducePayments.java	Added explicit cast to null for config file option
src/main/java/io/confluent/examples/streams/microservices/util/ProduceOrders.java	Added explicit cast to null for config file option
src/main/java/io/confluent/examples/streams/microservices/util/ProduceCustomers.java	Added explicit cast to null for config file option
src/main/java/io/confluent/examples/streams/microservices/util/ConsumePayments.java	Added explicit cast to null for config file option
src/main/java/io/confluent/examples/streams/microservices/util/ConsumeOrders.java	Added explicit cast to null for config file option
src/main/java/io/confluent/examples/streams/microservices/util/ConsumeCustomers.java	Added explicit cast to null for config file option
src/main/java/io/confluent/examples/streams/microservices/ValidationsAggregatorService.java	Added explicit cast to null for config file option
src/main/java/io/confluent/examples/streams/microservices/PostOrdersAndPayments.java	Added explicit cast to null for config file option
src/main/java/io/confluent/examples/streams/microservices/OrdersService.java	Added explicit cast to null for config file option
src/main/java/io/confluent/examples/streams/microservices/OrderDetailsService.java	Added explicit cast to null for config file option
src/main/java/io/confluent/examples/streams/microservices/InventoryService.java	Added explicit cast to null for config file option
src/main/java/io/confluent/examples/streams/microservices/FraudService.java	Added explicit cast to null for config file option
src/main/java/io/confluent/examples/streams/microservices/EmailService.java	Added explicit cast to null for config file option
src/main/java/io/confluent/examples/streams/microservices/AddInventory.java	Added explicit cast to null for config file option
pom.xml	Upgraded the commons-cli dependency version to 1.9.0

Comments suppressed due to low confidence (1)

pom.xml:119

Ensure that upgrading commons-cli to version 1.9.0 does not introduce breaking API changes and that compatibility with existing code is maintained.

<version>1.9.0</version>

Copilot · 2025-05-26T22:26:44Z

src/main/java/io/confluent/examples/streams/microservices/util/ProducePayments.java

@@ -37,7 +37,7 @@ public static void main(final String[] args) throws Exception {

        final CommandLine cl = new DefaultParser().parse(opts, args);

-        final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", null))
+        final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", (String) null))


[nitpick] The configuration loading code appears in multiple services. Consider extracting this repeated pattern into a helper method to reduce duplication.

Copilot · 2025-05-26T22:26:44Z

src/main/java/io/confluent/examples/streams/microservices/util/ProduceOrders.java

@@ -39,7 +39,7 @@ public static void main(final String[] args) throws Exception {

        final CommandLine cl = new DefaultParser().parse(opts, args);

-        final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", null))
+        final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", (String) null))


[nitpick] The configuration loading logic is repeated here. Consider centralizing this logic in a shared utility method to avoid redundancy.

Copilot · 2025-05-26T22:26:45Z

src/main/java/io/confluent/examples/streams/microservices/util/ProduceCustomers.java

@@ -45,7 +45,7 @@ public static void main(final String[] args) throws Exception {
            Collections.singletonMap(AbstractKafkaSchemaSerDeConfig.SCHEMA_REGISTRY_URL_CONFIG, schemaRegistryUrl),
            isKeySerde);

-        final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", null))
+        final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", (String) null))


[nitpick] The same configuration loading pattern is used repeatedly. Extracting this pattern into a helper method could improve maintainability.

Copilot · 2025-05-26T22:26:45Z

src/main/java/io/confluent/examples/streams/microservices/util/ConsumePayments.java

@@ -38,7 +38,7 @@ public static void main(final String[] args) throws Exception {
        final String bootstrapServers = cl.getOptionValue("b", DEFAULT_BOOTSTRAP_SERVERS);
        final String schemaRegistryUrl = cl.getOptionValue("schema-registry", DEFAULT_SCHEMA_REGISTRY_URL);

-        final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", null))
+        final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", (String) null))


[nitpick] The configuration loading logic is duplicated. Consider creating a common utility method to handle this pattern.

Copilot · 2025-05-26T22:26:45Z

src/main/java/io/confluent/examples/streams/microservices/util/ConsumeOrders.java

@@ -39,7 +39,7 @@ public static void main(final String[] args) throws Exception {
        final String bootstrapServers = cl.getOptionValue("b", DEFAULT_BOOTSTRAP_SERVERS);
        final String schemaRegistryUrl = cl.getOptionValue("schema-registry", DEFAULT_SCHEMA_REGISTRY_URL);

-        final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", null))
+        final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", (String) null))


[nitpick] The configuration file loading code is repeated; consider centralizing this logic to improve maintainability.

Copilot · 2025-05-26T22:26:47Z

src/main/java/io/confluent/examples/streams/microservices/OrderDetailsService.java

@@ -217,7 +217,7 @@ public static void main(final String[] args) throws Exception {
      formatter.printHelp("Order Details Service", opts);
      return;
    }
-    final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", null))
+    final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", (String) null))


[nitpick] The configuration loading pattern is repeated; abstracting this logic into a utility method could help reduce redundancy.

Copilot · 2025-05-26T22:26:47Z

src/main/java/io/confluent/examples/streams/microservices/InventoryService.java

@@ -200,7 +200,7 @@ public static void main(final String[] args) throws Exception {
      return;
    }

-    final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", null))
+    final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", (String) null))


[nitpick] The configuration loading code is reused in multiple locations; consider extracting it to a helper method to improve maintainability.

Copilot · 2025-05-26T22:26:47Z

src/main/java/io/confluent/examples/streams/microservices/FraudService.java

@@ -166,7 +166,7 @@ public static void main(final String[] args) throws Exception {
      return;
    }
    final FraudService service = new FraudService();
-    final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", null))
+    final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", (String) null))


[nitpick] The repeated configuration file loading code could be refactored into a common utility method for better maintainability.

Copilot · 2025-05-26T22:26:47Z

src/main/java/io/confluent/examples/streams/microservices/EmailService.java

@@ -152,7 +152,7 @@ public static void main(final String[] args) throws Exception {
    }
    final EmailService service = new EmailService(new LoggingEmailer());

-    final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", null))
+    final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", (String) null))


[nitpick] Consider extracting the configuration loading logic into a shared helper to avoid duplication across modules.

Copilot · 2025-05-26T22:26:48Z

src/main/java/io/confluent/examples/streams/microservices/AddInventory.java

@@ -77,7 +77,7 @@ public static void main(final String[] args) throws Exception {

        final String bootstrapServers = cl.getOptionValue("b", DEFAULT_BOOTSTRAP_SERVERS);

-        final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", null))
+        final Properties defaultConfig = Optional.ofNullable(cl.getOptionValue("config-file", (String) null))


[nitpick] The configuration loading code is duplicated; consider refactoring it into a utility function to reduce repetition.

chore(deps): update commons-cli version

f85472f

Copilot AI review requested due to automatic review settings May 26, 2025 22:23

mjsax requested review from a team as code owners May 26, 2025 22:23

Copilot AI reviewed May 26, 2025

View reviewed changes

mjsax closed this May 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(deps): update commons-cli version #556

chore(deps): update commons-cli version #556

Uh oh!

mjsax commented May 26, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 26, 2025

Uh oh!

Copilot AI May 26, 2025

Uh oh!

Copilot AI May 26, 2025

Uh oh!

Copilot AI May 26, 2025

Uh oh!

Copilot AI May 26, 2025

Uh oh!

Copilot AI May 26, 2025

Uh oh!

Copilot AI May 26, 2025

Uh oh!

Copilot AI May 26, 2025

Uh oh!

Copilot AI May 26, 2025

Uh oh!

Copilot AI May 26, 2025

Uh oh!

Uh oh!

chore(deps): update commons-cli version #556

chore(deps): update commons-cli version #556

Uh oh!

Conversation

mjsax commented May 26, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!